From: Greg KH <greg@kroah.com>
To: "Nguyen, Tom L" <tom.l.nguyen@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]PCI Express Port Bus Driver
Date: Fri, 17 Dec 2004 16:05:31 -0800 [thread overview]
Message-ID: <20041218000531.GC24586@kroah.com> (raw)
In-Reply-To: <C7AB9DA4D0B1F344BF2489FA165E5024073EBAE0@orsmsx404.amr.corp.intel.com>
On Wed, Dec 15, 2004 at 04:06:44PM -0800, Nguyen, Tom L wrote:
> On Wednesday, December 15, 2004 1:37 PM, Greg KH wrote:
> >> +config PCIEPORTBUS
> >> + bool "PCI Express support"
> >> + depends on PCI_GOMMCONFIG
> >
> > This should also work if PCI_GOANY is selected, right? Otherwise this
> > feature will never be turned on by any distro :(
> PCIE port bus driver depends on PCI_GOMMCONFIG to locate service
> attributes for advanced error reporting (AER) and virtual channel (VC)
> for each PCIE port. Without PCI_GOMMCONFIG, then a read to 0x100
> offset or above will return 0xffff; in other words, neither AER nor VC
> service support is found. We would like to move forward to have
> PCI_GOMMCONFIG dependency as the new features come along. RHEL 4 is
> shipping with PCI_GOMMCONFIG configured into the kernel by default and
> we expect the next major version of SuSE linux to do the same.
Hm, I get a oops message at boot time, on a non-pci express box, with
PCI_GOMMCONFIG enabled and your patch. Something down in the ACPI
subsystem.
Have you tested this kind of configuration?
I'll hold off on applying the patch for now due to this :)
thanks,
greg k-h
next prev parent reply other threads:[~2004-12-18 0:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-16 0:06 [PATCH]PCI Express Port Bus Driver Nguyen, Tom L
2004-12-18 0:05 ` Greg KH [this message]
2004-12-18 5:49 ` Tim Hockin
-- strict thread matches above, loose matches on Subject: below --
2004-12-23 1:23 long
2005-01-11 23:39 ` [PATCH]PCI " Greg KH
2004-12-21 21:02 Nguyen, Tom L
2004-12-21 19:46 Nguyen, Tom L
2004-12-21 19:56 ` Greg KH
2004-12-21 19:21 long
2004-12-21 18:57 ` [PATCH]PCI " Christoph Hellwig
2004-12-20 23:00 Nguyen, Tom L
2004-12-20 18:15 Nguyen, Tom L
2004-12-20 18:24 ` Greg KH
2004-12-18 0:44 Nguyen, Tom L
2004-12-18 0:37 Nguyen, Tom L
2004-12-15 22:27 long
2004-12-15 21:37 ` Greg KH
2004-12-18 0:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041218000531.GC24586@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox