From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261317AbULSRWV (ORCPT ); Sun, 19 Dec 2004 12:22:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261322AbULSRWV (ORCPT ); Sun, 19 Dec 2004 12:22:21 -0500 Received: from gprs215-234.eurotel.cz ([160.218.215.234]:640 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S261317AbULSRWQ (ORCPT ); Sun, 19 Dec 2004 12:22:16 -0500 Date: Sat, 18 Dec 2004 08:50:03 +0100 From: Pavel Machek To: Michael Frank Cc: Patrick Mochel , Nigel Cunningham , softwaresuspend-devel@lists.berlios.de, Linux Kernel Mailing List Subject: Re: [SoftwareSuspend-devel] 2.6 Suspend PM issues Message-ID: <20041218075003.GA3015@elf.ucw.cz> References: <200412171315.50463.mhf@berlios.de> <1103263067.19280.4.camel@desktop.cunninghams> <20041217092642.GH25573@elf.ucw.cz> <200412181014.30998.mhf@berlios.de> <20041218074202.GG29084@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041218074202.GG29084@elf.ucw.cz> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.6+20040722i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > > > By what was discussed wrt ALSA issue I gather that you still resume > > > > > _all_ drivers after doing the atomic copy? > > > > > > > > > > As explained earlier this year, if this is the case, it is firstly > > > > > unacceptable as it will result in loss of data in many applications and > > > > > secondly very clumsy. > > > > > > > > > > Example With 2.4 OK, with 2.6 It would fail: > > > > > A datalogger connected to a seral port of a notebook in the field. Data > > > > > transfer in progress which can be put on hold bo lowering RTS (HW > > > > > handshake) but _cannot_ be restarted. Battery low, must suspend to > > > > > change battery, upon resume transfer can continue. > > > > > > > > > > Will this be taken care of? > > > > > > Driver will get enough info in its resume routine ("hey, it is resume, > > > but it is only resume after atomic copy"), so it can ignore the resume > > > if it really needs to. > > > > Each driver has to make the decision when to ignore resume? that would add a > > lot of bloat as well as lots of work to implement and test the changes for > > 100s of drivers... > > No, only those drivers where extra resume does some damage. So far I > know about one, and that's your data logging device. ...which will not work anyway, swsusp1 or swsusp2. Have you actually tried it? During boot, BIOS is probably going to play with RTS anyway. So no matter what you do during suspend, you are probably going to screw it up anyway on the boot just before resume. So there are currently 0 examples where extra resume hurts. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!