From: Christoph Hellwig <hch@infradead.org>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH] cdu31a - more fixes
Date: Sun, 19 Dec 2004 13:36:07 +0000 [thread overview]
Message-ID: <20041219133607.GA599@infradead.org> (raw)
In-Reply-To: <41C4BD54.2060703@rainbow-software.org>
> +#define RETURN_UP(retval) do {up(&sony_sem); return (retval);} while(0)
Please don't use such obsfucation macros. Instead use gotos in the
functions to haev a single exit path that releases the lock.
next prev parent reply other threads:[~2004-12-19 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-18 23:29 [RFC] [PATCH] cdu31a - more fixes Ondrej Zary
2004-12-19 13:36 ` Christoph Hellwig [this message]
2004-12-19 21:45 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041219133607.GA599@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox