Re: [PATCH]PCI Express Port Bus Driver

[Greg KH <greg@kroah.com>]

On Mon, Dec 20, 2004 at 10:15:30AM -0800, Nguyen, Tom L wrote:
> Friday, December 17, 2004 4:06 PM, Greg KH wrote: 
> > Hm, I get a oops message at boot time, on a non-pci express box, with
> > PCI_GOMMCONFIG enabled and your patch.  Something down in the ACPI
> > subsystem. 
> >
> > Have you tested this kind of configuration?
> With PCI_GOMMCONFIG enabled and PCIE Port Bus driver included, I got
> kernel 
> panic at boot time on a non-pci express box. Similar to your case, I 
> observed something down in the ACPI subsystem. I tested the other case 
> where the kernel is built with PCI_GOMMCONFIG and without PCIE Port 
> Bus driver being included, same kernel panic occurred at boot time. I
> tested 
> another case where the kernel is built with PCI_GOANY and with PCIE Port
> 
> Bus driver being included, the kernel boots fine. Based on these test
> results, 
> it seems that PCI_GOMMCONFIG, not PCIE Port Bus driver, is a root cause 
> of kernel panic.
> 
> > I'll hold off on applying the patch for now due to this :)
> It seems that it is ok to apply the patch for now. What do you think?

I think you might want to either get the PCI_GOANY code to work with the
pci express driver, or fix up the PCI_GOMMCONFIG case in the acpi code,
as no distro will ever enable PCI_GOMMCONFIG in the current case :)

Sound ok?

thanks,

greg k-h