From: Adrian Bunk <bunk@stusta.de>
To: Arne Caspari <arnem@informatik.uni-bremen.de>
Cc: bcollins@debian.org, linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: updated: [2.6 patch] ieee1394_core.c: remove unneeded EXPORT_SYMBOL's
Date: Tue, 21 Dec 2004 01:42:37 +0100 [thread overview]
Message-ID: <20041221004237.GJ21288@stusta.de> (raw)
In-Reply-To: <20041220175156.GW21288@stusta.de>
On Mon, Dec 20, 2004 at 06:51:56PM +0100, Adrian Bunk wrote:
>...
> After grepping through your CVS sources, it seems hpsb_read and
> hpsb_write are the EXPORT_SYMBOLS affecting you?
> So keeping them should address your concerns?
>...
Updated patch that no longer removes these two EXPORT_SYMBOL's:
<-- snip -->
The patch below removes 39 unneeded EXPORT_SYMBOL's.
diffstat output:
drivers/ieee1394/ieee1394_core.c | 39 -------------------------------
1 files changed, 39 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc3-mm1-full/drivers/ieee1394/ieee1394_core.c.old 2004-12-20 01:24:23.000000000 +0100
+++ linux-2.6.10-rc3-mm1-full/drivers/ieee1394/ieee1394_core.c 2004-12-21 00:36:49.000000000 +0100
@@ -1194,9 +1194,7 @@
EXPORT_SYMBOL(hpsb_set_packet_complete_task);
EXPORT_SYMBOL(hpsb_alloc_packet);
EXPORT_SYMBOL(hpsb_free_packet);
-EXPORT_SYMBOL(hpsb_send_phy_config);
EXPORT_SYMBOL(hpsb_send_packet);
-EXPORT_SYMBOL(hpsb_send_packet_and_wait);
EXPORT_SYMBOL(hpsb_reset_bus);
EXPORT_SYMBOL(hpsb_bus_reset);
EXPORT_SYMBOL(hpsb_selfid_received);
@@ -1216,9 +1214,6 @@
EXPORT_SYMBOL(hpsb_make_isopacket);
EXPORT_SYMBOL(hpsb_read);
EXPORT_SYMBOL(hpsb_write);
-EXPORT_SYMBOL(hpsb_lock);
-EXPORT_SYMBOL(hpsb_lock64);
-EXPORT_SYMBOL(hpsb_send_gasp);
EXPORT_SYMBOL(hpsb_packet_success);
/** highlevel.c **/
@@ -1230,32 +1225,19 @@
EXPORT_SYMBOL(hpsb_listen_channel);
EXPORT_SYMBOL(hpsb_unlisten_channel);
EXPORT_SYMBOL(hpsb_get_hostinfo);
-EXPORT_SYMBOL(hpsb_get_host_bykey);
EXPORT_SYMBOL(hpsb_create_hostinfo);
EXPORT_SYMBOL(hpsb_destroy_hostinfo);
EXPORT_SYMBOL(hpsb_set_hostinfo_key);
-EXPORT_SYMBOL(hpsb_get_hostinfo_key);
EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
EXPORT_SYMBOL(hpsb_set_hostinfo);
-EXPORT_SYMBOL(highlevel_read);
-EXPORT_SYMBOL(highlevel_write);
-EXPORT_SYMBOL(highlevel_lock);
-EXPORT_SYMBOL(highlevel_lock64);
-EXPORT_SYMBOL(highlevel_add_host);
-EXPORT_SYMBOL(highlevel_remove_host);
EXPORT_SYMBOL(highlevel_host_reset);
/** nodemgr.c **/
-EXPORT_SYMBOL(hpsb_guid_get_entry);
-EXPORT_SYMBOL(hpsb_nodeid_get_entry);
EXPORT_SYMBOL(hpsb_node_fill_packet);
-EXPORT_SYMBOL(hpsb_node_read);
EXPORT_SYMBOL(hpsb_node_write);
-EXPORT_SYMBOL(hpsb_node_lock);
EXPORT_SYMBOL(hpsb_register_protocol);
EXPORT_SYMBOL(hpsb_unregister_protocol);
EXPORT_SYMBOL(ieee1394_bus_type);
-EXPORT_SYMBOL(nodemgr_for_each_host);
/** csr.c **/
EXPORT_SYMBOL(hpsb_update_config_rom);
@@ -1292,32 +1274,11 @@
EXPORT_SYMBOL(hpsb_iso_recv_flush);
/** csr1212.c **/
-EXPORT_SYMBOL(csr1212_create_csr);
-EXPORT_SYMBOL(csr1212_init_local_csr);
-EXPORT_SYMBOL(csr1212_new_immediate);
-EXPORT_SYMBOL(csr1212_new_leaf);
-EXPORT_SYMBOL(csr1212_new_csr_offset);
EXPORT_SYMBOL(csr1212_new_directory);
-EXPORT_SYMBOL(csr1212_associate_keyval);
EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
-EXPORT_SYMBOL(csr1212_new_extended_immediate);
-EXPORT_SYMBOL(csr1212_new_extended_leaf);
-EXPORT_SYMBOL(csr1212_new_descriptor_leaf);
-EXPORT_SYMBOL(csr1212_new_textual_descriptor_leaf);
-EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
-EXPORT_SYMBOL(csr1212_new_icon_descriptor_leaf);
-EXPORT_SYMBOL(csr1212_new_modifiable_descriptor_leaf);
-EXPORT_SYMBOL(csr1212_new_keyword_leaf);
EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
-EXPORT_SYMBOL(csr1212_disassociate_keyval);
EXPORT_SYMBOL(csr1212_release_keyval);
-EXPORT_SYMBOL(csr1212_destroy_csr);
EXPORT_SYMBOL(csr1212_read);
-EXPORT_SYMBOL(csr1212_generate_positions);
-EXPORT_SYMBOL(csr1212_generate_layout_order);
-EXPORT_SYMBOL(csr1212_fill_cache);
-EXPORT_SYMBOL(csr1212_generate_csr_image);
EXPORT_SYMBOL(csr1212_parse_keyval);
-EXPORT_SYMBOL(csr1212_parse_csr);
EXPORT_SYMBOL(_csr1212_read_keyval);
EXPORT_SYMBOL(_csr1212_destroy_keyval);
next prev parent reply other threads:[~2004-12-21 0:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-20 1:53 [2.6 patch] ieee1394_core.c: remove unneeded EXPORT_SYMBOL's Adrian Bunk
2004-12-20 2:10 ` Dan Dennedy
2004-12-20 2:25 ` Adrian Bunk
2004-12-20 2:42 ` Lee Revell
2004-12-20 4:27 ` Dan Dennedy
2004-12-20 22:53 ` Adrian Bunk
2004-12-20 22:58 ` Lee Revell
2004-12-20 23:02 ` Adrian Bunk
2004-12-20 23:21 ` Lee Revell
2004-12-21 0:40 ` Alan Cox
2004-12-21 17:17 ` Greg KH
2004-12-21 17:20 ` Lee Revell
2004-12-21 17:27 ` Greg KH
2004-12-21 22:19 ` Theodore Ts'o
2004-12-22 14:08 ` Alan Cox
2004-12-20 9:01 ` Arne Caspari
2004-12-20 12:15 ` Arjan van de Ven
2004-12-20 13:20 ` Arne Caspari
2004-12-20 14:35 ` Alan Cox
2004-12-22 8:29 ` Arjan van de Ven
2004-12-22 8:57 ` Stefan Richter
2004-12-22 12:01 ` Christoph Hellwig
2004-12-22 12:21 ` Arne Caspari
2004-12-22 16:04 ` Stefan Richter
2004-12-20 14:39 ` Ben Collins
2004-12-20 15:15 ` Alan Cox
2004-12-20 15:46 ` Ben Collins
2004-12-20 20:15 ` Alan Cox
2004-12-21 8:33 ` Arne Caspari
2004-12-21 12:00 ` Adrian Bunk
2004-12-21 12:49 ` Arne Caspari
2004-12-21 17:15 ` Greg KH
2004-12-21 18:51 ` Arne Caspari
2004-12-21 18:58 ` Greg KH
2004-12-20 17:51 ` Adrian Bunk
2004-12-20 21:05 ` Lee Revell
2004-12-20 21:49 ` girish wadhwani
2004-12-21 8:37 ` Arne Caspari
2004-12-21 9:06 ` Bernard Leach
2004-12-21 23:35 ` Pieter Palmers
2004-12-22 0:56 ` Lee Revell
2004-12-21 0:42 ` Adrian Bunk [this message]
2004-12-21 8:46 ` updated: " Arne Caspari
2004-12-21 17:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041221004237.GJ21288@stusta.de \
--to=bunk@stusta.de \
--cc=arnem@informatik.uni-bremen.de \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox