From: Jesse Barnes <jbarnes@engr.sgi.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
willy@debian.org
Subject: Re: [PATCH] add PCI API to sysfs
Date: Tue, 21 Dec 2004 08:22:35 -0800 [thread overview]
Message-ID: <200412210822.35949.jbarnes@engr.sgi.com> (raw)
In-Reply-To: <1103613004.21771.25.camel@gaston>
On Monday, December 20, 2004 11:10 pm, Benjamin Herrenschmidt wrote:
> > > +static int mmap(struct file *file, struct vm_area_struct *vma)
> > > +{
>
> Also, just a style comment: I dislike when functions have such a
> "generic" name like mmap. I'd _much_ prefer something like pcisysfs_mmap
> or something like that. The simple name makes it confusing in
> System.map/kallsyms and thus when debugging.
True, but I was just following the convention in bin.c. Maybe that could be
cleaned up all at once with a separate patch? There's some whitespace I'd
like to cleanup in pci-sysfs.c as well, so I could do both at once.
Jesse
prev parent reply other threads:[~2004-12-21 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-20 22:50 [PATCH] add PCI API to sysfs Jesse Barnes
2004-12-20 22:58 ` Greg KH
2004-12-20 23:01 ` Jesse Barnes
2004-12-21 7:12 ` Benjamin Herrenschmidt
2004-12-21 12:31 ` Matthew Wilcox
2004-12-21 16:13 ` Benjamin Herrenschmidt
2004-12-21 17:05 ` Greg KH
2004-12-21 17:20 ` Jesse Barnes
2004-12-21 7:10 ` Benjamin Herrenschmidt
2004-12-21 16:22 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200412210822.35949.jbarnes@engr.sgi.com \
--to=jbarnes@engr.sgi.com \
--cc=benh@kernel.crashing.org \
--cc=bjorn.helgaas@hp.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox