public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Horms <horms@verge.net.au>
To: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: solar@openwall.com, Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: [PATCH] binfmt_elf force_sig arguments fix
Date: Tue, 21 Dec 2004 21:37:47 +0900	[thread overview]
Message-ID: <20041221123744.GA2294@verge.net.au> (raw)

Hi,

There appears to be a small error in the change that was recently
applied to fs/binfmt_elf.c to fix error codes and eraly corrupt
binary detection.

The patch includes changing a send_sig() call to a force_sig() call in
load_elf_binary(). However force_sig() only accepts 2 arguments, and
thus the patch causes the build to fail.

I propose the following patch to simply remove the extra argument to
force_sig(), which I beleive will give a sensible result.  That or
change the call back to send_sig(), though I assume it was changed to
force_sig() for a reason.

-- 
Horms

===== fs/binfmt_elf.c 1.36 vs edited =====
--- 1.36/fs/binfmt_elf.c	2004-12-18 03:17:46 +09:00
+++ edited/fs/binfmt_elf.c	2004-12-21 21:21:25 +09:00
@@ -806,7 +806,7 @@
 		if (BAD_ADDR(elf_entry)) {
 			printk(KERN_ERR "Unable to load interpreter %.128s\n",
 				elf_interpreter);
-			force_sig(SIGSEGV, current, 0);
+			force_sig(SIGSEGV, current);
 			retval = -ENOEXEC; /* Nobody gets to see this, but.. */
 			goto out_free_dentry;
 		}

             reply	other threads:[~2004-12-21 12:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-21 12:37 Horms [this message]
2004-12-21 10:37 ` [PATCH] binfmt_elf force_sig arguments fix Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041221123744.GA2294@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=solar@openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox