Re: [PATCH] binfmt_elf force_sig arguments fix

Re: [PATCH] binfmt_elf force_sig arguments fix

[Marcelo Tosatti]

On Tue, Dec 21, 2004 at 09:37:47PM +0900, Horms wrote:
> Hi,
> 
> There appears to be a small error in the change that was recently
> applied to fs/binfmt_elf.c to fix error codes and eraly corrupt
> binary detection.
> 
> The patch includes changing a send_sig() call to a force_sig() call in
> load_elf_binary(). However force_sig() only accepts 2 arguments, and
> thus the patch causes the build to fail.
> 
> I propose the following patch to simply remove the extra argument to
> force_sig(), which I beleive will give a sensible result.  That or
> change the call back to send_sig(), though I assume it was changed to
> force_sig() for a reason.

Applied, thanks.

> -- 
> Horms
> 
> ===== fs/binfmt_elf.c 1.36 vs edited =====
> --- 1.36/fs/binfmt_elf.c	2004-12-18 03:17:46 +09:00
> +++ edited/fs/binfmt_elf.c	2004-12-21 21:21:25 +09:00
> @@ -806,7 +806,7 @@
>  		if (BAD_ADDR(elf_entry)) {
>  			printk(KERN_ERR "Unable to load interpreter %.128s\n",
>  				elf_interpreter);
> -			force_sig(SIGSEGV, current, 0);
> +			force_sig(SIGSEGV, current);
>  			retval = -ENOEXEC; /* Nobody gets to see this, but.. */
>  			goto out_free_dentry;
>  		}

[PATCH] binfmt_elf force_sig arguments fix

[Horms]

Hi,

There appears to be a small error in the change that was recently
applied to fs/binfmt_elf.c to fix error codes and eraly corrupt
binary detection.

The patch includes changing a send_sig() call to a force_sig() call in
load_elf_binary(). However force_sig() only accepts 2 arguments, and
thus the patch causes the build to fail.

I propose the following patch to simply remove the extra argument to
force_sig(), which I beleive will give a sensible result.  That or
change the call back to send_sig(), though I assume it was changed to
force_sig() for a reason.

-- 
Horms

===== fs/binfmt_elf.c 1.36 vs edited =====
--- 1.36/fs/binfmt_elf.c	2004-12-18 03:17:46 +09:00
+++ edited/fs/binfmt_elf.c	2004-12-21 21:21:25 +09:00
@@ -806,7 +806,7 @@
 		if (BAD_ADDR(elf_entry)) {
 			printk(KERN_ERR "Unable to load interpreter %.128s\n",
 				elf_interpreter);
-			force_sig(SIGSEGV, current, 0);
+			force_sig(SIGSEGV, current);
 			retval = -ENOEXEC; /* Nobody gets to see this, but.. */
 			goto out_free_dentry;
 		}