public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Chris Friesen <cfriesen@nortelnetworks.com>
Cc: Al Hooton <al@hootons.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: ioctl assignment strategy?
Date: Tue, 21 Dec 2004 09:24:10 -0800	[thread overview]
Message-ID: <20041221172410.GG1459@kroah.com> (raw)
In-Reply-To: <41C70DF2.80101@nortelnetworks.com>

On Mon, Dec 20, 2004 at 11:37:54AM -0600, Chris Friesen wrote:
> Greg KH wrote:
> 
> >Rethink the way you want to control your device.  Seriously, a lot of
> >ioctls can be broken down into single device files, single sysfs files,
> >or other such things (a whole new fs as a last resort too.)
> 
> Actually, my particular case is likely not a good example.  We've got a 
> misc char driver giving access to a lot of miscellaneous features we've 
> added to the kernel,.  We originally (a few years back) used new syscalls, 
> but then we started supporting a bunch more arches, and having to patch all 
> of them just to add syscall numbers sucked.
> 
> Some of it could easily be moved to /proc or /sys, but if you do it that 
> way, how do you handle returning unusual error values?  Other stuff 
> involves multiple stages of registration, then getting handles returned, 
> and doing new calls with those handles.  I don't see how this would tie 
> nicely into the read/write paradigm.

Multiple files?  One per type of action?  Without a full description of
what you are doing I don't really have a good answer.

> What's the big problem with ioctls anyways?  I mean, in a closed 
> environment where I'm writing both the userspace and the kernelspace side 
> of things.

ioctls are basically a simple way to add any kind of syscall to the
kernel.  They also have nasty 32/64 bit issues.  Because we want to have
well-defined syscalls that work on all platforms, and not any arbitrary
type of call, it is good to restrict ioctls.

See the other comments about this topic in the lkml archives.

thanks,

greg k-h

  parent reply	other threads:[~2004-12-21 17:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-14 23:31 ioctl assignment strategy? Al Hooton
2004-12-15  0:46 ` Greg KH
2004-12-15 14:53   ` Chris Friesen
2004-12-17 23:48     ` Greg KH
2004-12-20 17:37       ` Chris Friesen
2004-12-20 22:48         ` Pjotr Kourzanov
2004-12-21  0:32           ` Alan Cox
2004-12-21  2:06             ` Lee Revell
2004-12-21 12:51             ` Olivier Galibert
2004-12-21 17:24         ` Greg KH [this message]
2004-12-22 17:16   ` Al Hooton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041221172410.GG1459@kroah.com \
    --to=greg@kroah.com \
    --cc=al@hootons.org \
    --cc=cfriesen@nortelnetworks.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox