Re: [2.6 patch] ieee1394_core.c: remove unneeded EXPORT_SYMBOL's

Adrian Bunk
2004-12-20T02:25:13Z

On Sun, Dec 19, 2004 at 09:10:10PM -0500, Dan Dennedy wrote:
> On Mon, 2004-12-20 at 02:53 +0100, Adrian Bunk wrote:
> > The patch below removes 41 unneeded EXPORT_SYMBOL's.
>
> Unneeded according to whom, just you? These functions are part of an
> API. How do I know someone is not using these in a custom ieee1394
> kernel module in some industrial or research setting or something new
> under development to be contributed to linux1394 project?

If someone uses some of them in code to be contributed to the linux1394
project, re-adding the EXPORT_SYMBOL's in question is trivial.

If someone uses some of them in a custom setting, re-adding them is
trivial, too.

If the only user of one or more of these EXPORT_SYMBOL's was a non-free
module, it's kernel policy that the EXPORT_SYMBOL's in question have to
be removed.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed