From: Greg KH <greg@kroah.com>
To: Jesse Barnes <jbarnes@engr.sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add mmap support to struct bin_attribute files
Date: Tue, 21 Dec 2004 09:46:48 -0800 [thread overview]
Message-ID: <20041221174648.GA8000@kroah.com> (raw)
In-Reply-To: <200412210932.54961.jbarnes@engr.sgi.com>
On Tue, Dec 21, 2004 at 09:32:54AM -0800, Jesse Barnes wrote:
> * Copyright (c) 2001,2002 Patrick Mochel
> + * Copyright (c) 2004 Silicon Graphics, Inc.
Minor nit, some copyright lawyers I know say it should be (C) not (c),
for what it's worth...
> +struct vm_area_struct; /* circular dependencies? */
Drop the comment :)
> struct bin_attribute {
> struct attribute attr;
> size_t size;
> + void *private;
Why the private pointer? Don't you get everything you need in the
kobject itself?
thanks,
greg k-h
next prev parent reply other threads:[~2004-12-21 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-21 17:32 [PATCH] add mmap support to struct bin_attribute files Jesse Barnes
2004-12-21 17:46 ` Greg KH [this message]
2004-12-21 18:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041221174648.GA8000@kroah.com \
--to=greg@kroah.com \
--cc=jbarnes@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox