From: Greg KH <greg@kroah.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Jesse Barnes <jbarnes@engr.sgi.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
willy@debian.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH] add legacy resources to sysfs
Date: Tue, 21 Dec 2004 13:44:42 -0800 [thread overview]
Message-ID: <20041221214442.GA10362@kroah.com> (raw)
In-Reply-To: <20041221212839.GF31261@parcelfarce.linux.theplanet.co.uk>
On Tue, Dec 21, 2004 at 09:28:39PM +0000, Matthew Wilcox wrote:
> > ===== arch/ia64/sn/pci/pci_dma.c 1.2 vs edited =====
> > +int sn_pci_get_legacy_mem(struct pci_bus *bus, unsigned long *addr)
> > +{
> > + if (!SN_PCIBUS_BUSSOFT(bus))
> > + return -ENODEV;
> > +
> > + *addr = SN_PCIBUS_BUSSOFT(bus)->bs_legacy_mem | __IA64_UNCACHED_OFFSET;
> > +
> > + return 0;
> > +}
>
> int sn_pci_get_legacy_mem(struct pci_bus *bus)
> {
> if (!SN_PCIBUS_BUSSOFT(bus))
> return ERR_PTR(-ENODEV);
Huh? A pointer doesn't fit into an int on all arches. I think the
original was correct.
thanks,
greg k-h
next prev parent reply other threads:[~2004-12-21 21:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-21 20:47 [PATCH] add legacy resources to sysfs Jesse Barnes
2004-12-21 21:28 ` Matthew Wilcox
2004-12-21 21:44 ` Greg KH [this message]
2004-12-21 21:49 ` Jesse Barnes
2004-12-21 21:46 ` Greg KH
2004-12-21 22:05 ` Jesse Barnes
2004-12-21 23:42 ` Jesse Barnes
2004-12-22 0:05 ` Greg KH
2004-12-22 0:14 ` Jesse Barnes
2004-12-22 0:20 ` Greg KH
2004-12-22 8:38 ` Benjamin Herrenschmidt
2004-12-22 16:09 ` Greg KH
2004-12-22 16:34 ` Benjamin Herrenschmidt
2004-12-22 16:58 ` Jesse Barnes
2004-12-22 18:31 ` Jesse Barnes
2004-12-22 21:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041221214442.GA10362@kroah.com \
--to=greg@kroah.com \
--cc=benh@kernel.crashing.org \
--cc=bjorn.helgaas@hp.com \
--cc=jbarnes@engr.sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox