From: Greg KH <greg@kroah.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: linux-usb-devel@lists.sourcefoge.net.kroah.org,
linux-kernel@vger.kernel.org, laforge@gnumonks.org
Subject: Re: My vision of usbmon
Date: Tue, 21 Dec 2004 21:06:24 -0800 [thread overview]
Message-ID: <20041222050624.GC31076@kroah.com> (raw)
In-Reply-To: <20041221172906.3b9cbbbd@lembas.zaitcev.lan>
On Tue, Dec 21, 2004 at 05:29:06PM -0800, Pete Zaitcev wrote:
> On Tue, 21 Dec 2004 16:57:26 -0800, Greg KH <greg@kroah.com> wrote:
>
> > It looks great, thanks for doing this work. Let me know when you want
> > it added to the kernel tree.
>
> Thanks, Greg. There's a little tidbit in usbmon about which I wish you to
> make a pronouncement explicitly:
>
> + /* XXX Is this how I pin struct bus? Ask linux-usb-devel */
> + kobject_get(&ubus->class_dev.kobj);
> + mbus->u_bus = ubus;
> + ubus->mon_bus = mbus;
Use usb_bus_get() instead. Ick, that function's implementation sucks,
I'll go clean it up and export it for you to be able to use from your
code.
thanks,
greg k-h
next prev parent reply other threads:[~2004-12-22 5:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-20 7:04 My vision of usbmon Pete Zaitcev
[not found] ` <200412201255.59120.oliver@neukum.org>
2004-12-20 12:21 ` [linux-usb-devel] " Pete Zaitcev
2004-12-22 0:57 ` Greg KH
2004-12-22 1:29 ` Pete Zaitcev
2004-12-22 5:06 ` Greg KH [this message]
2004-12-22 5:10 ` Greg KH
2004-12-22 1:38 ` Nick Piggin
2004-12-22 5:04 ` Greg KH
2004-12-22 5:34 ` Jeff Garzik
2004-12-22 6:43 ` Greg KH
[not found] ` <200412201525.52149.oliver@neukum.org>
2004-12-22 2:25 ` Pete Zaitcev
2004-12-22 5:03 ` Greg KH
2004-12-22 20:46 ` Oliver Neukum
-- strict thread matches above, loose matches on Subject: below --
2004-12-23 21:02 Chad Kitching
2005-01-11 1:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041222050624.GC31076@kroah.com \
--to=greg@kroah.com \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourcefoge.net.kroah.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox