Re: My vision of usbmon

Pete Zaitcev
2004-12-22T01:29:20Z

On Tue, 21 Dec 2004 16:57:26 -0800, Greg KH <greg@kroah.com> wrote:

> It looks great, thanks for doing this work. Let me know when you want
> it added to the kernel tree.

Thanks, Greg. There's a little tidbit in usbmon about which I wish you to
make a pronouncement explicitly:

+ /* XXX Is this how I pin struct bus? Ask linux-usb-devel */
+ kobject_get(&ubus->class_dev.kobj);
+ mbus->u_bus = ubus;
+ ubus->mon_bus = mbus;

Is this a good way to guarantee that mbus->u_bus won't be dangling?
This is used not just when someone pulls a PCMCIA card, but also
in case of plain rmmod ohci-hcd.

-- Pete