RE: My vision of usbmon

Chad Kitching
2004-12-23T21:03:06Z

> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: December 21, 2004 11:11 PM
> Subject: Re: My vision of usbmon
>
> -/* exported only within usbcore */
> -struct usb_bus *usb_bus_get (struct usb_bus *bus)
> +struct usb_bus *usb_bus_get(struct usb_bus *bus)
> {
> - struct class_device *tmp;
> -
> - if (!bus)
> - return NULL;
> -
> - tmp = class_device_get(&bus->class_dev);
> - if (tmp)
> - return to_usb_bus(tmp);
> - else
> - return NULL;
> + if (bus)
> + class_device_get(&bus->class_dev);
> + return bus;
> }
> +EXPORT_SYMBOL_GPL(usb_bus_get);

I'm not familiar with this code, but if the replacement code is
equivalent, is there any point to the return usb_bus pointer? With
the replacement, you should always get the same pointer you put
into it. If that is the case, why not remove the return value, and
change drivers/usb/core/usb.c to match?

Chad Kitching