From: William Lee Irwin III <wli@holomorphy.com>
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: 2.6.x BUGs at boot time (APIC related)
Date: Thu, 23 Dec 2004 01:12:43 -0800 [thread overview]
Message-ID: <20041223091243.GA771@holomorphy.com> (raw)
In-Reply-To: <200412231102.10171.vda@port.imtp.ilyichevsk.odessa.ua>
On Wednesday 22 December 2004 17:31, Denis Vlasenko wrote:
>> if (!apic_id_registered())
>> BUG(); <=========================
On Thu, Dec 23, 2004 at 11:02:09AM +0000, Denis Vlasenko wrote:
> Tested with noapic nolapic boot params. Still happens.
> Call chain is init() -> APIC_init_uniprocessor() ->
> -> setup_local_APIC(). I am a bit suspicious why
> APIC_init_uniprocessor() does not bail out
> if enable_local_apic<0 (i.e. if I boot with "nolapic"):
> int __init APIC_init_uniprocessor (void)
> {
> if (enable_local_apic < 0)
> clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
> <===== missing "return -1"?
>
> if (!smp_found_config && !cpu_has_apic)
> return -1;
> ...
Sounds pretty serious. What happens if you add the missing return -1?
-- wli
next prev parent reply other threads:[~2004-12-23 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-22 17:31 2.6.x BUGs at boot time (APIC related) Denis Vlasenko
2004-12-23 11:02 ` Denis Vlasenko
2004-12-23 9:12 ` William Lee Irwin III [this message]
2004-12-23 14:57 ` Denis Vlasenko
2004-12-23 9:33 ` Arnaud Patard
-- strict thread matches above, loose matches on Subject: below --
2004-12-23 16:11 Mikael Pettersson
2004-12-23 16:22 ` William Lee Irwin III
2004-12-23 16:59 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041223091243.GA771@holomorphy.com \
--to=wli@holomorphy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox