Re: [PATCH] fix conflicting cpu_idle() declarations

William Lee Irwin III
2004-12-27T16:09:20Z

On Mon, Dec 27, 2004 at 07:10:38PM +0300, Oleg Nesterov wrote:
> cpu_idle() declared/defined in
> init/main.c: void cpu_idle(void)
> i386/kernel/process.c void cpu_idle(void)
> i386/kernel/smpboot.c: int cpu_idle(void)
> i386/mach-voyager/voyager_smp.c: int cpu_idle(void)
> ppc/kernel/idle.c: int cpu_idle(void)
> ppc/kernel/smp.c: int cpu_idle(void *unused)
> ppc64/kernel/idle.c: int cpu_idle(void)
> ppc64/kernel/smp.c: int cpu_idle(void *unused)
> sparc/kernel/process.c: int cpu_idle(void)
> sparc64/kernel/process.c: int cpu_idle(void)
> sh/kernel/process.c: void cpu_idle(void *unused)
> sh/kernel/smp.c: int cpu_idle(void *unused)
> ia64/kernel/smpboot.c: int cpu_idle(void)
> ia64/kernel/process.c: void cpu_idle(void *unused)

It's remarkable that several arches are internally inconsistent. Anyway,
this will likely be a shoo-in, as it removes more code than it adds. The
mess surrounding cpu_idle() has been aggravating for some time.

-- wli