Re: [patch] fix sparc64 cpu_idle()

Mitchell Blank Jr
2004-12-29T22:51:59Z

(cc: list trimmed)

Coywolf Qi Hunt wrote:
> - int ret = -EPERM;
> -
> - if (current->pid != 0)
> - goto out;
> -

Maybe just a WARN_ON(current->pid != 0) would be a good compromise... I
imagine that someone added the check for some reason but you're right that
just returning an error code (that presumably noone checks, right?) doesn't
make much sense

-Mitch