public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, arjan@infradead.org,
	alan@lxorguk.ukuu.org.uk, mingo@redhat.com
Subject: Re: PATCH: 2.6.10 - Misrouted IRQ recovery for review
Date: Tue, 28 Dec 2004 10:25:50 -0800	[thread overview]
Message-ID: <20041228102550.42dbb028.davem@davemloft.net> (raw)
In-Reply-To: <200412281228.27307.dtor_core@ameritech.net>

On Tue, 28 Dec 2004 12:28:27 -0500
Dmitry Torokhov <dtor_core@ameritech.net> wrote:

> From what I saw the only thing that presently uses pt_rergs is SysRq
> handler to print the call trace and if we slightly change the semantics
> (instead of printing the trace immediately raise a flag and when next
> interrupt arrives check it in do_IRQ and print the trace from there -
> I even had some patches) we could drop pt_regs. I would very much like
> to do so at least for input drivers.

Are you going to take a snapshot at IRQ time?  If not, then I'm
pretty much against this change.  When I do a sysrq regs dump,
I want the exact pt_regs values at interrupt time, not some
random value later in time.

Perhaps instead you could raise a flag in the input driver, and
at the top-level interrupt dispatch arch code do the register
sysrq dump.  This gives the same semantics as present, and also
allows you what you want for the input drivers.

But, even with this, there is the x86 interrupt handler Alan
mentioned which wants the pt_regs too.

  reply	other threads:[~2004-12-28 18:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-28 15:58 PATCH: 2.6.10 - Misrouted IRQ recovery for review Alan Cox
2004-12-28 17:11 ` Arjan van de Ven
2004-12-28 16:37   ` Alan Cox
2004-12-28 17:28   ` Dmitry Torokhov
2004-12-28 18:25     ` David S. Miller [this message]
2004-12-28 18:50       ` Dmitry Torokhov
2004-12-28 18:53         ` David S. Miller
2004-12-28 19:21           ` Dmitry Torokhov
2004-12-28 19:26             ` David S. Miller
2004-12-29 13:57 ` Ingo Molnar
2005-01-01 17:59 ` Pavel Machek
2005-01-01 20:41 ` Bill Davidsen
2005-01-02 15:18   ` Alan Cox
2005-01-02 17:47     ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041228102550.42dbb028.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjan@infradead.org \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox