From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Coywolf Qi Hunt <coywolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [patch] fix sparc64 cpu_idle()
Date: Wed, 29 Dec 2004 14:56:15 -0800 [thread overview]
Message-ID: <20041229225615.GC70906@gaz.sfgoth.com> (raw)
In-Reply-To: <2cd57c9004122911523fe7a71b@mail.gmail.com>
(cc: list trimmed)
Coywolf Qi Hunt wrote:
> - int ret = -EPERM;
> -
> - if (current->pid != 0)
> - goto out;
> -
Maybe just a WARN_ON(current->pid != 0) would be a good compromise... I
imagine that someone added the check for some reason but you're right that
just returning an error code (that presumably noone checks, right?) doesn't
make much sense
-Mitch
next prev parent reply other threads:[~2004-12-29 22:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-27 16:10 [PATCH] fix conflicting cpu_idle() declarations Oleg Nesterov
2004-12-27 16:08 ` William Lee Irwin III
2004-12-29 19:07 ` [patch] fix sparc64 cpu_idle() Coywolf Qi Hunt
2004-12-29 19:52 ` Coywolf Qi Hunt
2004-12-29 22:56 ` Mitchell Blank Jr [this message]
2004-12-30 16:31 ` Oleg Nesterov
2004-12-28 2:55 ` [PATCH] fix conflicting cpu_idle() declarations Hirokazu Takata
2004-12-28 3:09 ` William Lee Irwin III
2004-12-28 3:48 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041229225615.GC70906@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=coywolf@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox