Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state

Jan-Benedict Glaw
2004-12-30T09:48:43Z

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

On Thu, 2004-12-30 03:48:34 -0500, David Dillow <dave@thedillows.org>
wrote in message <20041230035000.10@ori.thedillows.org>:
> diff -Nru a/include/net/xfrm.h b/include/net/xfrm.h
> --- a/include/net/xfrm.h 2004-12-30 01:12:08 -05:00
> +++ b/include/net/xfrm.h 2004-12-30 01:12:08 -05:00
> @@ -146,6 +146,9 @@
> /* Private data of this transformer, format is opaque,
> * interpreted by xfrm_type methods. */
> void *data;
> +
> + /* Intended direction of this state, used for offloading */
> + int dir;
> };
>
> enum {
> @@ -157,6 +160,12 @@
> XFRM_STATE_DEAD
> };
>
> +enum {
> + XFRM_STATE_DIR_UNKNOWN,
> + XFRM_STATE_DIR_IN,
> + XFRM_STATE_DIR_OUT,
> +};

Any specific reason to first define such a nice enum and then using int
in the struct?

MfG, JBG

--
Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 _ O _
"Eine Freie Meinung in einem Freien Kopf | Gegen Zensur | Gegen Krieg _ _ O
fuer einen Freien Staat voll Freier Bürger" | im Internet! | im Irak! O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]