From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MMC block removable flag
Date: Thu, 30 Dec 2004 09:54:48 +0000 [thread overview]
Message-ID: <20041230095448.A9500@flint.arm.linux.org.uk> (raw)
In-Reply-To: <41D3646F.5050408@drzeus.cx>; from drzeus-list@drzeus.cx on Thu, Dec 30, 2004 at 03:14:07AM +0100
On Thu, Dec 30, 2004 at 03:14:07AM +0100, Pierre Ossman wrote:
> A MMC card is a highly removable device. This patch makes the block
> layer part of the MMC layer set the removable flag.
I have this patch also floating around, but I've decided it isn't needed.
I believe this flag is to indicate that we have removable media for a
block device rather than to indicate that the block device can be removed.
However, when we insert and remove a MMC card, we create and destroy the
block device itself. Therefore, as far as the block layer is concerned,
the device itself is being inserted and removed, so telling the block
layer that the media is removable is just silly - you can't separate the
flash media from the on-board MMC controller.
(Note: any block device can be removed - you just rmmod the module
supplying the block device driver, but this doesn't mean we mark all
block devices with GENHD_FL_REMOVABLE.)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-12-30 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-30 2:14 [PATCH] MMC block removable flag Pierre Ossman
2004-12-30 9:54 ` Russell King [this message]
2004-12-30 15:56 ` Pierre Ossman
2005-01-07 12:39 ` Russell King
2005-01-07 14:00 ` Andries Brouwer
2005-01-08 11:09 ` Russell King
2005-01-08 12:05 ` Christoph Hellwig
2005-01-08 12:45 ` Russell King
2005-01-08 13:07 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041230095448.A9500@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox