public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andrew Morton <akpm@osdl.org>
Cc: William Park <opengeometry@yahoo.ca>,
	juhl-lkml@dif.dk, linux-kernel@vger.kernel.org
Subject: Re: waiting 10s before mounting root filesystem?
Date: Fri, 31 Dec 2004 06:28:26 -0200	[thread overview]
Message-ID: <20041231082826.GE7081@logos.cnet> (raw)
In-Reply-To: <20041231014905.30b05a11.akpm@osdl.org>

On Fri, Dec 31, 2004 at 01:49:05AM -0800, Andrew Morton wrote:
> William Park <opengeometry@yahoo.ca> wrote:
> >
> > -		printk("VFS: Cannot open root device \"%s\" or %s\n",
> >  -				root_device_name, b);
> >  -		printk("Please append a correct \"root=\" boot option\n");
> >  +		if (--tryagain) {
> >  +		    printk (KERN_WARNING "VFS: Waiting %dsec for root device...\n", tryagain);
> >  +		    ssleep (1);
> >  +		    goto retry;
> >  +		}
> >  +		printk (KERN_CRIT "VFS: Cannot open root device \"%s\" or %s\n", root_device_name, b);
> >  +		printk (KERN_CRIT "Please append a correct \"root=\" boot option\n");
> 
> Why is this patch needed?  If it is to offer the user a chance to insert
> the correct medium or to connect the correct device, 

The media may take a while to become readable (think of CDROM).

> why not rely upon the user doing that thing and then hitting reset? 

I think this is not the case (only) case the patch covers up.

Yes its ugly.


  reply	other threads:[~2004-12-31 11:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-27 19:56 waiting 10s before mounting root filesystem? William Park
2004-12-27 20:10 ` Trent Lloyd
2004-12-27 21:23   ` Andreas Unterkircher
2004-12-28  1:54     ` Eric Lammerts
2004-12-29  0:59     ` William Park
2004-12-29  1:38       ` Jesper Juhl
2004-12-29  1:56         ` William Park
2004-12-29 12:49           ` Paulo Marques
2004-12-29 19:15             ` William Park
2004-12-29 19:34               ` Paulo Marques
2004-12-29 20:59                 ` William Park
2004-12-29 21:26                   ` Andreas Steinmetz
2004-12-31 19:32                     ` Willy Tarreau
2004-12-29 21:53                   ` Bernd Eckenfels
2004-12-29 22:56                 ` Jesper Juhl
2004-12-30 15:25       ` Marcelo Tosatti
2004-12-30 23:45         ` Jesper Juhl
2004-12-31  1:45           ` Jesper Juhl
2004-12-31  3:58             ` William Park
2004-12-31  4:41               ` Jesper Juhl
2004-12-31 11:31                 ` Paulo Marques
2004-12-31  9:49               ` Andrew Morton
2004-12-31  8:28                 ` Marcelo Tosatti [this message]
2004-12-31 11:40                   ` Andrew Morton
2004-12-31 11:26                 ` Paulo Marques
2004-12-31  8:58                   ` Marcelo Tosatti
2004-12-31 11:42                   ` Andrew Morton
2004-12-31 12:04                     ` Paulo Marques
2004-12-31 17:36                     ` William Park
2004-12-31 17:48                       ` Tomasz Torcz
2004-12-31 18:18                         ` William Park
2004-12-31  0:22         ` William Park
     [not found] <fa.nc4oh06.1j1872e@ifi.uio.no>
     [not found] ` <fa.nalafoa.1ih25aa@ifi.uio.no>
2004-12-31 12:33   ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041231082826.GE7081@logos.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=akpm@osdl.org \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opengeometry@yahoo.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox