From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: James Nelson <james4765@verizon.net>,
kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] esp: Make driver SMP-correct
Date: Fri, 31 Dec 2004 10:00:37 +0000 [thread overview]
Message-ID: <20041231100037.A29868@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20041231014611.003281e5.akpm@osdl.org>; from akpm@osdl.org on Fri, Dec 31, 2004 at 01:46:11AM -0800
On Fri, Dec 31, 2004 at 01:46:11AM -0800, Andrew Morton wrote:
> James Nelson <james4765@verizon.net> wrote:
> >
> > This is an attempt to make the esp serial driver SMP-correct. It also removes
> > some cruft left over from the serial_write() conversion.
>
> >From a quick scan:
>
> - startup() does multiple sleeping allocations and request_irq() under
> spin_lock_irqsave(). Maybe fixed by this:
However, can you guarantee that two threads won't enter startup() at
the same time? (that's what ASYNC_INITIALIZED is protecting the
function against, and the corresponding shutdown() as well.)
It's probably better to port ESP to the serial_core structure where
this type of thing is already taken care of.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-12-31 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-31 1:43 [PATCH] esp: Make driver SMP-correct James Nelson
2004-12-31 9:45 ` Jan Dittmer
2004-12-31 9:46 ` Andrew Morton
2004-12-31 10:00 ` Russell King [this message]
2004-12-31 11:00 ` Jim Nelson
2004-12-31 17:01 ` Russell King
2004-12-31 22:16 ` [KJ] " Jim Nelson
2005-01-01 0:01 ` Gene Heskett
2005-01-01 0:13 ` Russell King
2005-01-01 1:14 ` Gene Heskett
2005-01-01 1:33 ` Russell King
2005-01-01 1:49 ` Jim Nelson
2005-01-01 1:35 ` Gene Heskett
2005-01-01 1:47 ` Jim Nelson
2005-01-01 3:11 ` Gene Heskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041231100037.A29868@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=james4765@verizon.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox