From: Christoph Hellwig <hch@lst.de>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] remove dead OSS/AC97 code
Date: Fri, 31 Dec 2004 15:36:00 +0100 [thread overview]
Message-ID: <20041231143600.GA9210@lst.de> (raw)
--- 1.5/sound/oss/ac97.c 2004-05-29 11:13:01 +02:00
+++ edited/sound/oss/ac97.c 2004-12-31 14:30:35 +01:00
@@ -133,7 +133,7 @@ ac97_reset (struct ac97_hwint *dev)
/* Return the contents of register REG; use the cache if the value in it
is valid. Returns a negative error code on failure. */
-int
+static int
ac97_get_register (struct ac97_hwint *dev, u8 reg)
{
if (reg > 127 || (reg & 1))
@@ -226,7 +226,7 @@ ac97_scale_from_oss_val (int value, int
}
}
-int
+static int
ac97_set_mixer (struct ac97_hwint *dev, int oss_channel, u16 oss_value)
{
int scaled_value;
@@ -262,7 +262,7 @@ ac97_set_mixer (struct ac97_hwint *dev,
return result;
}
-int
+static int
ac97_get_mixer_scaled (struct ac97_hwint *dev, int oss_channel)
{
struct ac97_chn_desc *channel = ac97_find_chndesc (dev, oss_channel);
@@ -439,10 +439,7 @@ ac97_mixer_ioctl (struct ac97_hwint *dev
EXPORT_SYMBOL(ac97_init);
EXPORT_SYMBOL(ac97_set_values);
-EXPORT_SYMBOL(ac97_set_mixer);
-EXPORT_SYMBOL(ac97_get_register);
EXPORT_SYMBOL(ac97_put_register);
-EXPORT_SYMBOL(ac97_get_mixer_scaled);
EXPORT_SYMBOL(ac97_mixer_ioctl);
EXPORT_SYMBOL(ac97_reset);
MODULE_LICENSE("GPL");
===== sound/oss/ac97.h 1.4 vs edited =====
--- 1.4/sound/oss/ac97.h 2004-05-29 11:13:01 +02:00
+++ edited/sound/oss/ac97.h 2004-12-31 14:30:35 +01:00
@@ -184,25 +184,9 @@ extern int ac97_init (struct ac97_hwint
extern int ac97_set_values (struct ac97_hwint *dev,
struct ac97_mixer_value_list *value_list);
-/* Sets one mixer channel OSS_CHANNEL to the scaled value OSS_VALUE.
- Returns the resulting (rescaled) value, or a negative value
- representing an error code.
-
- Stereo channels have two values in OSS_VALUE (the left value is in the
- lower 8 bits, the right value is in the upper 8 bits). */
-extern int ac97_set_mixer (struct ac97_hwint *dev, int oss_channel,
- u16 oss_value);
-
-/* Return the contents of the specified AC97 register REG; it uses the
- last-written value if it is available. */
-extern int ac97_get_register (struct ac97_hwint *dev, u8 reg);
-
/* Writes the specified VALUE to the AC97 register REG in the mixer.
Takes care of setting the last-written cache as well. */
extern int ac97_put_register (struct ac97_hwint *dev, u8 reg, u16 value);
-
-/* Returns the last OSS value written to the OSS_CHANNEL mixer channel. */
-extern int ac97_get_mixer_scaled (struct ac97_hwint *dev, int oss_channel);
/* Default ioctl. */
extern int ac97_mixer_ioctl (struct ac97_hwint *dev, unsigned int cmd,
next reply other threads:[~2004-12-31 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-31 14:36 Christoph Hellwig [this message]
2004-12-31 16:21 ` [PATCH] remove dead OSS/AC97 code Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041231143600.GA9210@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox