From: Paul Mundt <lethal@linux-sh.org>
To: linux-kernel@vger.kernel.org
Cc: kaos@ocs.com.au, sam@ravnborg.org
Subject: sh: inconsistent kallsyms data
Date: Fri, 31 Dec 2004 19:25:50 +0200 [thread overview]
Message-ID: <20041231172549.GA18211@linux-sh.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]
Building 2.6.10 for sh results in inconsistent kallsyms data. Turning on
CONFIG_KALLSYMS_ALL fixes it, as does CONFIG_KALLSYMS_EXTRA_PASS.
The symbols that seem to be problematic between the second and third
pass are all kallsyms special symbols. With only CONFIG_KALLSYMS set we
see:
--- System.map 2004-12-31 10:53:10.278567522 -0600
+++ .tmp_System.map 2004-12-31 10:53:10.347558024 -0600
@@ -6868,9 +6868,9 @@
8817c4d0 D kallsyms_addresses
88182660 D kallsyms_num_syms
88182670 D kallsyms_names
-88190630 D kallsyms_markers
-881906a0 D kallsyms_token_table
-88190b50 D kallsyms_token_index
+881906a0 D kallsyms_markers
+88190710 D kallsyms_token_table
+88190bc0 D kallsyms_token_index
88191000 D irq_desc
88191000 A __per_cpu_end
88191000 A __per_cpu_start
So for some reason we have a 0x70 variance between these, and only
these. Running with --all-symbols this seems to work fine.
Looking at scripts/kallsyms.c:symbol_valid, we see:
/* Symbols which vary between passes. Passes 1 and 2 must have
* identical symbol lists. The kallsyms_* symbols below are only added
* after pass 1, they would be included in pass 2 when --all-symbols is
* specified so exclude them to get a stable symbol list.
*/
Going by this it's not entirely clear if there is a problem or not. If
these symbols are supposed to be excluded due to being "special", then
it doesn't seem like verify_kallsyms in the top-level Makefile is doing
the right thing by just doing a blind cmp -s. This comment also seems to
be a bit outdated or just generally inaccurate, as --all-symbols isn't
the default behaviour unless CONFIG_KALLSYMS_ALL is set.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2004-12-31 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-31 17:25 Paul Mundt [this message]
2004-12-31 17:59 ` sh: inconsistent kallsyms data pmarques
2004-12-31 18:22 ` Paul Mundt
2004-12-31 19:29 ` pmarques
2004-12-31 19:42 ` Paul Mundt
2004-12-31 18:15 ` Keith Owens
2005-01-01 3:59 ` Keith Owens
2005-01-01 4:15 ` Keith Owens
2005-01-01 9:01 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041231172549.GA18211@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox