From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751712AbdL2RtG (ORCPT ); Fri, 29 Dec 2017 12:49:06 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:41782 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbdL2RtE (ORCPT ); Fri, 29 Dec 2017 12:49:04 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171229174901epoutp018cfc637955e83140df68aed9f64bcc87~E1SfiN0ub2866128661epoutp013 X-AuditID: b6c32a36-3bdff7000000117d-14-5a46800c7f96 From: Bartlomiej Zolnierkiewicz To: SF Markus Elfring Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, Tony Prisk , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb_probe() Date: Fri, 29 Dec 2017 18:48:58 +0100 Message-id: <2004567.mMJ8BiHiPi@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <8f4f12ca-f2b3-6b3b-5f4c-5519f13c474f@users.sourceforge.net> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsWy7bCmni5Pg1uUwd35ZhZXvr5nszjfuZzZ YustaYtNj6+xWpzo+8BqcXnXHDaLlssrmB3YPe53H2fy2Lyk3uP8/xZ2j6ZT7awenzfJBbBG cdmkpOZklqUW6dslcGXcntjHVjCHq2Lr4ZPsDYzrOboYOTkkBEwkTh3cxdLFyMUhJLCDUaJz 7wVGCOc7o8TDW72MMFVtn3dCVe1mlPj3dyVU1VdGicl3+8Cq2ASsJCa2rwKyOThEBEwl/pwI AalhFrjCKDHhx2xmkLiwQLnEs1eCIOUsAqoS66dfYgKxeQU0JbZd3M0GYosKeEls2dcOFucU 8JQ4P+MNM0SNoMSPyfdYQGxmAXmJffunskLYOhJnj60Du0dC4ACbxOEzO9ggrnaRuLB4EpQt LPHq+BZ2kBskBKQlLh21hQhPZ5TY/lsConczo8Sq3RPYIRLWEoePX4RawCfx7msPK0Qvr0RH mxBEiYfEwp4maAA5SixZNosdEiZzGCX29GxhmsAoOwvJ3bOQ3D0Lyd0LGJlXMYqlFhTnpqcW GxYY6RUn5haX5qXrJefnbmIEJwgtsx2Mi875HGIU4GBU4uHlSHeNEmJNLCuuzD3EKMHBrCTC a13jFiXEm5JYWZValB9fVJqTWnyIUZqDRUmcNyDAJUpIID2xJDU7NbUgtQgmy8TBKdXAyBlw bub6gkVcmXW9FmFtUtIF/tPLisQnlP28YKV+UDnA/kGHSPmJdfu3rL1w45zAldvbjyl2ljPd fcf4yXIj00lTx6383hOZDUIO2gv6m2yrZlVaY+OZ9UqLV2qj7sNIUeWtitpyJXubo11Yp0mw Ptwt4x2XlDtf0KCrVcaJ+yVD63Hjj5OUWIozEg21mIuKEwEtUzWuDAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jAV2eBrcog2NzxS2ufH3PZnG+czmz xdZb0habHl9jtTjR94HV4vKuOWwWLZdXMDuwe9zvPs7ksXlJvcf5/y3sHk2n2lk9Pm+SC2CN 4rJJSc3JLEst0rdL4Mq4PbGPrWAOV8XWwyfZGxjXc3QxcnJICJhItH3eydLFyMUhJLCTUWLT ly1MEM5XRolfnW9ZQKrYBKwkJravYuxi5OAQETCV+HMiBKSGWeAKo8T+iefZQeLCAuUSz7oV QcpZBFQl1k+/xARi8wpoSmy7uJsNxBYV8JLYsq8dLM4p4ClxfsYbZohd84AWLz/KDNEgKPFj 8j2wvcwC8hL79k9lhbC1JNbvPM40gZF/FpKyWUjKZiEpW8DIvIpRMrWgODc9t9iowDAvtVyv ODG3uDQvXS85P3cTIzCktx3W6tvBeH9J/CFGAQ5GJR5ejnTXKCHWxLLiytxDjBIczEoivNY1 blFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeW/nHYsUEkhPLEnNTk0tSC2CyTJxcEo1MGocyDFb EHXAl9XP57LFFbdzN1anHhZR1ZXXuLep5CaLwt5X5u2LK6d3pp2YsHTB0USDMwknpxb13NSR ebkz5f+Fpu3R3bo37v7wWrLmwT2ZD94SNZdkddiXTW+e+OwIh/uczIthjXIXD3XXvEs9+fVC r3Ty8UVp/PMMVpxZsvxBcKmyzIr6ba5KLMUZiYZazEXFiQDIonC9ZQIAAA== X-CMS-MailID: 20171229174900epcas1p236a809f1c2df6423f75fc28f7c30bf2d X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20171124193022epcas5p2dddfdb636f02793037a470d0932ed6c4 X-RootMTR: 20171124193022epcas5p2dddfdb636f02793037a470d0932ed6c4 References: <8f4f12ca-f2b3-6b3b-5f4c-5519f13c474f@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, November 24, 2017 08:30:04 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 24 Nov 2017 20:22:10 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/video/fbdev/wm8505fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/wm8505fb.c b/drivers/video/fbdev/wm8505fb.c > index 253ffe9baab2..8f0d5379861d 100644 > --- a/drivers/video/fbdev/wm8505fb.c > +++ b/drivers/video/fbdev/wm8505fb.c > @@ -276,10 +276,8 @@ static int wm8505fb_probe(struct platform_device *pdev) > > fbi = devm_kzalloc(&pdev->dev, sizeof(struct wm8505fb_info) + > sizeof(u32) * 16, GFP_KERNEL); > - if (!fbi) { > - dev_err(&pdev->dev, "Failed to initialize framebuffer device\n"); > + if (!fbi) > return -ENOMEM; > - } This removes the information about the device for which the allocation fails (but as there can be only one wm8505fb device in the system this change is okay). Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics