Re: [PATCH][1/2] adjust dirty threshold for lowmem-only mappings

William Lee Irwin III
2004-12-26T03:16:38Z

William Lee Irwin III <wli@holomorphy.com> writes:
[...]
>> Lifting the artificial lowmem restrictions on blockdev mappings
>> (thereby nuking mapping->gfp_mask altogether) would resolve a number of
>> problems, not that anything making that much sense could ever happen.

On Sun, Dec 26, 2004 at 01:03:14AM +0300, Nikita Danilov wrote:
> mapping->gfp_mask is used for other things beyond specifying a
> zonelist. For example, file systems want all allocations inside a
> transaction to be done with GFP_NOFS, which forces GFP_NOFS in
> mapping->gfp_mask of meta-data address_spaces.

It's news to me, but benign. ->gfp_mask appears to be folded into
some bitflag word now so there wouldn't be an inode size reduction
anyway. Per-mapping gfp masks sound like a poor fit from the above.

-- wli