From: Daniel Jacobowitz <dan@debian.org>
To: Andi Kleen <ak@muc.de>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
davidel@xmailserver.org, mh@codeweavers.com,
the3dfxdude@gmail.com
Subject: Re: [PATCH] Fix typo in i386 single step changes
Date: Sun, 2 Jan 2005 18:41:55 -0500 [thread overview]
Message-ID: <20050102234155.GA29453@nevyn.them.org> (raw)
In-Reply-To: <m1brc7xv98.fsf@muc.de>
On Mon, Jan 03, 2005 at 12:32:19AM +0100, Andi Kleen wrote:
>
> Fix an obvious typo in the recent i386 single stepping changes.
>
> I would recommend to redo all the Wine etc. testing that lead to this patch
> since it probably never worked.
>
> Signed-off-by: Andi Kleen <ak@muc.de>
>
> --- linux-2.6.10-bk5/arch/i386/kernel/traps.c-o Mon Jan 3 01:02:06 2005
> +++ linux-2.6.10-bk5/arch/i386/kernel/traps.c Mon Jan 3 01:03:05 2005
> @@ -725,7 +725,7 @@
> if (tsk->ptrace & PT_DTRACE) {
> regs->eflags &= ~TF_MASK;
> tsk->ptrace &= ~PT_DTRACE;
> - if (!tsk->ptrace & PT_DTRACE)
> + if (!(tsk->ptrace & PT_DTRACE))
> goto clear_TF;
> }
> }
That test is still wrong... the bit is cleared on the previous line.
Is it supposed to be testing something else entirely?
--
Daniel Jacobowitz
next prev parent reply other threads:[~2005-01-02 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-02 23:32 [PATCH] Fix typo in i386 single step changes Andi Kleen
2005-01-02 23:41 ` Daniel Jacobowitz [this message]
2005-01-03 0:01 ` Andi Kleen
2005-01-03 1:41 ` Linus Torvalds
2005-01-03 1:11 ` Linus Torvalds
2005-01-03 3:30 ` Jesse Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050102234155.GA29453@nevyn.them.org \
--to=dan@debian.org \
--cc=ak@muc.de \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mh@codeweavers.com \
--cc=the3dfxdude@gmail.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox