From: Adrian Bunk <bunk@stusta.de>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [-mm patch] cachefs: possible cleanups
Date: Tue, 4 Jan 2005 00:53:40 +0100 [thread overview]
Message-ID: <20050103235340.GS2980@stusta.de> (raw)
The patch below contains the following possible cleanups:
- journal.c: make cachefs_ondisc_ujnl_marks static
- misc.c: #if 0 the unused global function __cachefs_page_get_private
diffstat output:
fs/cachefs/journal.c | 2 +-
fs/cachefs/misc.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-mm1-full/fs/cachefs/journal.c.old 2005-01-03 23:53:49.000000000 +0100
+++ linux-2.6.10-mm1-full/fs/cachefs/journal.c 2005-01-03 23:54:09.000000000 +0100
@@ -19,7 +19,7 @@
#define UJNL_WRAP(X) ((X) & (CACHEFS_ONDISC_UJNL_NUMENTS - 1))
-const char *cachefs_ondisc_ujnl_marks[] = {
+static const char *cachefs_ondisc_ujnl_marks[] = {
"Null ",
"Batch ",
"Ack ",
--- linux-2.6.10-mm1-full/fs/cachefs/misc.c.old 2005-01-03 23:54:20.000000000 +0100
+++ linux-2.6.10-mm1-full/fs/cachefs/misc.c 2005-01-03 23:54:37.000000000 +0100
@@ -30,6 +30,7 @@
* get a page caching token from for a page, allocating it and attaching it to
* the page's private pointer if it doesn't exist
*/
+#if 0
struct fscache_page * __cachefs_page_get_private(struct page *page,
unsigned gfp_flags)
{
@@ -51,6 +52,7 @@
} /* end __cachefs_page_get_private() */
EXPORT_SYMBOL(__cachefs_page_get_private);
+#endif /* 0 */
/*****************************************************************************/
/*
next reply other threads:[~2005-01-04 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 23:53 Adrian Bunk [this message]
2005-01-04 8:49 ` [-mm patch] cachefs: possible cleanups Martin Waitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050103235340.GS2980@stusta.de \
--to=bunk@stusta.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox