From: Olaf Hering <olh@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] request_irq: avoid slash in proc directory entries
Date: Wed, 5 Jan 2005 14:53:13 +0100 [thread overview]
Message-ID: <20050105135313.GB22571@suse.de> (raw)
In-Reply-To: <1104928634.24187.168.camel@localhost.localdomain>
On Wed, Jan 05, Alan Cox wrote:
> On Mer, 2005-01-05 at 07:53, Olaf Hering wrote:
> > diff -purNx tags linux-2.6.10.orig/drivers/net/wan/hostess_sv11.c linux-2.6.10-olh/drivers/net/wan/hostess_sv11.c
> > --- linux-2.6.10.orig/drivers/net/wan/hostess_sv11.c 2004-08-14 07:37:27.000000000 +0200
> > +++ linux-2.6.10-olh/drivers/net/wan/hostess_sv11.c 2005-01-01 19:34:46.000000000 +0100
> > @@ -263,7 +263,7 @@ static struct sv11_device *sv11_init(int
> > /* We want a fast IRQ for this device. Actually we'd like an even faster
> > IRQ ;) - This is one driver RtLinux is made for */
> >
> > - if(request_irq(irq, &z8530_interrupt, SA_INTERRUPT, "Hostess SV/11", dev)<0)
> > + if(request_irq(irq, &z8530_interrupt, SA_INTERRUPT, "Hostess SV-11", dev)<0)
> > {
> > printk(KERN_WARNING "hostess: IRQ %d already in use.\n", irq);
> > goto fail1;
>
> SV11 would probably be better but fine by me as the sv11 author
Ok, and GPIO1-ADB could be 'GPIO1 ADB'. Andrew, want a new patch?
prev parent reply other threads:[~2005-01-05 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 7:53 [PATCH] request_irq: avoid slash in proc directory entries Olaf Hering
2005-01-05 8:01 ` Andrew Morton
2005-01-05 9:34 ` Olaf Hering
2005-01-05 19:22 ` [PATCH] prohibit slash in proc directory entry names Nathan Lynch
2005-01-06 0:07 ` Andrew Morton
2005-01-06 0:12 ` Nathan Lynch
2005-01-05 12:37 ` [PATCH] request_irq: avoid slash in proc directory entries Alan Cox
2005-01-05 13:53 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050105135313.GB22571@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox