Re: 2.6.9+ keyboard LED problem

[Dmitry Torokhov <dtor_core@ameritech.net>]

On Wednesday 05 January 2005 07:12 pm, Ville Hallik wrote:
> In article <d120d50005010510543532e0bf@mail.gmail.com> you wrote:
> > On Wed, 5 Jan 2005 20:38:34 +0200 (EET), Meelis Roos <mroos@linux.ee> wrote:
> >> > Seems to work fine here. The led is blinking rapidly but I can type just
> >> > fine and touchpad works as well.
> >> >
> >> > What kind of box do you have? UP/SMP, Preempt?
> >> 
> >> UP, Celeron 900 on i815. Happens on 2 identical computers, one preempt,
> >> one not preempt. PS/2 keyboard and mouse on one, only PS/2 keyboard on
> >> the other (and USB mouse that is probably unimportant).
> >>
> 
> > The big input update went in with 2.6.9-rc2-bk4.Could you try booting
> > -bk3 and -bk4 to verify that those changes are to blame?
> 
> No, this bug appears with 2.6.9-rc2-bk3. I'm afraid that introduction of
> atkbd_schedule_command() & related stuff into atkbd.c is to blame.
> 

Actually it is ACK processing hardening that is very useful at setup stage
but is getting in our way once keyboard is initialized and commands are
intermixed with good data.

Could you please try the patch below? It is just a quick hack, just to prove
the idea. If it works for you I will prepare the proper fix later.

-- 
Dmitry

===== drivers/input/serio/libps2.c 1.2 vs edited =====
--- 1.2/drivers/input/serio/libps2.c	2004-10-20 03:13:08 -05:00
+++ edited/drivers/input/serio/libps2.c	2005-01-06 01:20:11 -05:00
@@ -250,7 +250,7 @@
 			}
 			/* Fall through */
 		default:
-			return 1;
+			return 0;
 	}
 
 	if (!ps2dev->nak && ps2dev->cmdcnt)