From: Martin Hicks <mort@wildopensource.com>
To: Marco Cipullo <cipullo@libero.it>, clameter@sgi.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: From last __GFP_ZERO changes
Date: Fri, 7 Jan 2005 14:33:54 -0500 [thread overview]
Message-ID: <20050107193354.GT18461@localhost> (raw)
In-Reply-To: <200501061243.58968.cipullo@libero.it>
On Thu, Jan 06, 2005 at 12:43:58PM +0100, Marco Cipullo wrote:
> From last __GFP_ZERO changes:
>
> --- a/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> +++ b/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> @@ -135,12 +135,10 @@
> goto no_bio;
>
> for (i = 0; i < PAGES_PER_PACKET; i++) {
> - pkt->pages[i] = alloc_page(GFP_KERNEL);
> + pkt->pages[i] = alloc_page(GFP_KERNEL|| __GFP_ZERO);
>
> Is this OK?
>
> Or should be
>
> for (i = 0; i < PAGES_PER_PACKET; i++) {
> - pkt->pages[i] = alloc_page(GFP_KERNEL);
> + pkt->pages[i] = alloc_page(GFP_KERNEL| __GFP_ZERO);
It definitely should be the latter.
CCing Christoph so he can fix this up.
mh
--
Martin Hicks Wild Open Source Inc.
mort@wildopensource.com 613-266-2296
next prev parent reply other threads:[~2005-01-07 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 11:43 From last __GFP_ZERO changes Marco Cipullo
2005-01-07 19:33 ` Martin Hicks [this message]
2005-01-07 20:02 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050107193354.GT18461@localhost \
--to=mort@wildopensource.com \
--cc=cipullo@libero.it \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox