From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kj <kernel-janitors@lists.osdl.org>, lkml <linux-kernel@vger.kernel.org>
Cc: bcollins@debian.org, linux1394-devel@lists.sourceforge.net
Subject: [UPDATE PATCH] ieee1394/sbp2: use ssleep() instead of schedule_timeout()
Date: Fri, 7 Jan 2005 13:34:00 -0800 [thread overview]
Message-ID: <20050107213400.GD2924@us.ibm.com> (raw)
In-Reply-To: <20041225004846.GA19373@nd47.coderock.org>
On Sat, Dec 25, 2004 at 01:48:46AM +0100, Domen Puncer wrote:
> Hi.
>
> Santa brought another present :-)
>
> I'll start mailing new patches these days, and after external trees get
> merged, I'll be bugging you with the old ones.
>
>
> Patchset is at http://coderock.org/kj/2.6.10-kj/
<snip>
> all patches:
> ------------
<snip>
> msleep-drivers_ieee1394_sbp2.patch
Please consider updating to the following patch:
Description: Use ssleep() instead of schedule_timeout() to guarantee the task
delays as expected. The existing code should not really need to run in
TASK_INTERRUPTIBLE, as there is no check for signals (or even an early return
value whatsoever). ssleep() takes care of these issues.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.10-v/drivers/ieee1394/sbp2.c 2004-12-24 13:34:00.000000000 -0800
+++ 2.6.10/drivers/ieee1394/sbp2.c 2005-01-05 14:23:05.000000000 -0800
@@ -902,8 +902,7 @@ alloc_fail:
* connected to the sbp2 device being removed. That host would
* have a certain amount of time to relogin before the sbp2 device
* allows someone else to login instead. One second makes sense. */
- set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(HZ);
+ ssleep(1);
/*
* Login to the sbp-2 device
next prev parent reply other threads:[~2005-01-07 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-25 0:48 [announce] 2.6.10-kj Domen Puncer
2005-01-07 19:33 ` [UPDATE PATCH] atm/ambassador: use msleep() instead of schedule_timeout() Nishanth Aravamudan
2005-01-07 19:40 ` [UPDATE PATCH] ide/ide-cd: use ssleep() " Nishanth Aravamudan
2005-01-07 19:47 ` Jens Axboe
2005-01-15 0:58 ` Bartlomiej Zolnierkiewicz
2005-01-07 21:34 ` Nishanth Aravamudan [this message]
2005-01-09 9:01 ` [UPDATE PATCH] ieee1394/sbp2: " Stefan Richter
2005-01-10 17:39 ` Nishanth Aravamudan
2005-01-14 4:52 ` Dan Dennedy
2005-01-14 11:16 ` Stefan Richter
2005-01-19 6:27 ` [KJ] " Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050107213400.GD2924@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=bcollins@debian.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox