public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
	Al Viro <viro@ftp.uk.linux.org>, Jens Axboe <axboe@suse.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MMC block removable flag
Date: Sat, 8 Jan 2005 11:09:57 +0000	[thread overview]
Message-ID: <20050108110957.D7065@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050107140035.GA5920@pclin040.win.tue.nl>; from aebr@win.tue.nl on Fri, Jan 07, 2005 at 03:00:35PM +0100

On Fri, Jan 07, 2005 at 03:00:35PM +0100, Andries Brouwer wrote:
> On Fri, Jan 07, 2005 at 12:39:47PM +0000, Russell King wrote:
> > Can anyone comment on the purpose of this (GENHD_FL_REMOVABLE) flag?
> > Al?  Jens?
> 
> GENHD_FL_REMOVABLE is set by a number of drivers (floppy, CDROM, ...).
> It is used in two places:
> (1) to fill the file /sys/block/*/removable
> (2) in genhd to suppress listing a nonpartitioned removable device
> in /proc/partitions.
> 
> In other words, it is for user space only, precisely as Pierre Ossman said.

Your point 2 isn't user space though.

Also, it's buggy.  Consider a SCSI PCMCIA card with SCSI disks attached.
When you eject that card, your SCSI disks disappear, yet they aren't
marked as removable.  If user space is relying on /sys/block/*/removable
to tell it if things may go away, then user space is buggy.

Maybe it's for devices which may be present (eg, floppy driver), but
which have removable media (eg, floppy disk), rather than removable
devices?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

  reply	other threads:[~2005-01-08 11:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-30  2:14 [PATCH] MMC block removable flag Pierre Ossman
2004-12-30  9:54 ` Russell King
2004-12-30 15:56   ` Pierre Ossman
2005-01-07 12:39     ` Russell King
2005-01-07 14:00       ` Andries Brouwer
2005-01-08 11:09         ` Russell King [this message]
2005-01-08 12:05           ` Christoph Hellwig
2005-01-08 12:45             ` Russell King
2005-01-08 13:07           ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050108110957.D7065@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=aebr@win.tue.nl \
    --cc=axboe@suse.de \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ftp.uk.linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox