public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: keventd gives exceptional priority to usermode helpers
Date: Mon, 10 Jan 2005 03:42:02 -0800	[thread overview]
Message-ID: <20050110034202.P469@build.pdx.osdl.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0501101121370.11128@yvahk01.tjqt.qr>; from jengelh@linux01.gwdg.de on Mon, Jan 10, 2005 at 11:28:38AM +0100

* Jan Engelhardt (jengelh@linux01.gwdg.de) wrote:
> --- usr_A/src/kotd/linux-2.6.8-20041204030200/kernel/kmod.c	2004-12-06 14:28:44.000000000 +0100
> +++ usr_B/src/kotd/linux-2.6.8-20041204030200/kernel/kmod.c	2005-01-06 11:44:04.130600000 +0100
> @@ -165,6 +165,7 @@ static int ____call_usermodehelper(void 
>  
>  	/* We can run anywhere, unlike our parent keventd(). */
>  	set_cpus_allowed(current, CPU_MASK_ALL);
> +        set_user_nice(current, 0);

Seems reasonable.  Although, I don't see a niceval of -20, but -5 on
keventd (workqueues do set_user_nice(-5)).  Also, this patch is
whitespace damaged, should be tab not spaces.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2005-01-10 11:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-10 10:28 keventd gives exceptional priority to usermode helpers Jan Engelhardt
2005-01-10 11:42 ` Chris Wright [this message]
2005-01-10 11:50   ` Jan Engelhardt
2005-01-11 12:11     ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050110034202.P469@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox