From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261581AbVALX0X (ORCPT ); Wed, 12 Jan 2005 18:26:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261578AbVALX0E (ORCPT ); Wed, 12 Jan 2005 18:26:04 -0500 Received: from mail.kroah.org ([69.55.234.183]:42381 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261560AbVALXYJ (ORCPT ); Wed, 12 Jan 2005 18:24:09 -0500 Date: Wed, 12 Jan 2005 15:19:08 -0800 From: Greg KH To: James Bottomley Cc: SCSI Mailing List , Linux Kernel Subject: Re: [PATCH] Add attribute container to the generic device model Message-ID: <20050112231908.GC15085@kroah.com> References: <1105506370.10378.26.camel@mulgrave> <20050112070802.GB2085@kroah.com> <1105561045.8030.2.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1105561045.8030.2.camel@mulgrave> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 12, 2005 at 02:17:25PM -0600, James Bottomley wrote: > How about the attached. It makes all the symbols EXPORT_SYMBOL_GPL, > updates the docs for the attribute_container_add_device function and > also integrates with the driver_init() function of drivers/base. Looks good to me. Feel free to push this with your scsi tree and you can add: Signed-off-by: Greg Kroah-Hartman if you want to. Again, nice job. Now lets see about adding some pressure to SATA to use this :) thanks, greg k-h