Re: [PATCH 1/1] tpm: fix cause of SMP stack traces

Chris Wright
2005-01-18T22:48:30Z

* Kylene Hall (kjhall@us.ibm.com) wrote:
> I actually had to move the location of some of the locks to remove the
> might sleep warnings.

Ah, that sounds like the proper fix.

> Since I didn't know much about the might sleep
> warnings before, my first course of action was to try using the disable
> irq mechanism and I went ahead and just left them in once it was working
> with the new lock placements. I assume you believe they shouldn't be
> necessary at all?

Right. Unless you're taking same spin_lock in irq context (which I
didn't recall you were doing).

thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net