Re: [PATCH 1/1] tpm: implement use of sysfs classes

Kylene Hall
2005-02-04T21:52:37Z

On Fri, 2005-02-04 at 14:52, Greg KH wrote:
> On Fri, Feb 04, 2005 at 02:12:50PM -0600, Kylene Hall wrote:
> > +static struct class tpm_class = {
> > + .name = "tpm",
> > + .class_dev_attrs = tpm_attrs,
> > +};
>
> Where is your release function? Did you see any warnings from the
> kernel when you removed any of these class devices? Why did you ignore
> it?
>
Sorry, I missed the warning message. I have looked at some other
instances for what I might need to put in that function and I'm
stumped. I didn't kmalloc my class_device structure so I don't need to
kfree it. I am using this mechanism so that my sysfs stuff is in a
predictable place. It is also very convient how the driver and device
links as well as all my class specific files get created for me in the
register and likewise removed in the unregister. I call the register
from the pci probe path and the unregister from the pci remove path.
What might I need to put in this function?

Thanks,
Kylie

> thanks,
>
> greg k-h
>