From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>, ecashin@coraid.com
Subject: [BUG] ATA over Ethernet __init calling __exit
Date: Thu, 13 Jan 2005 00:09:49 +0000 [thread overview]
Message-ID: <20050113000949.A7449@flint.arm.linux.org.uk> (raw)
static void __exit
aoe_exit(void)
{
...
}
static int __init
aoe_init(void)
{
...
aoe_exit();
...
}
Enough said, please shoot the author of that in the foot. You can't
call functions marked __exit (which may be discarded) from functions
which aren't. If you want to do this, please loose the __exit on
aoe_exit().
In addition, please shoot the author in the other foot for:
config ATA_OVER_ETH
tristate "ATA over Ethernet support"
depends on NET
default m <==== this line.
That's not nice for embedded guys who do a "make xxx_defconfig" and
unsuspectingly end up with ATA over Ethernet built in for their
platform.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next reply other threads:[~2005-01-13 0:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-13 0:09 Russell King [this message]
2005-01-13 8:50 ` [BUG] ATA over Ethernet __init calling __exit Jens Axboe
2005-01-13 19:36 ` Andi Kleen
2005-01-13 20:52 ` Ed L Cashin
2005-01-13 21:53 ` Andi Kleen
2005-01-13 22:09 ` Alan Cox
2005-01-13 22:12 ` Ed L Cashin
2005-01-13 22:48 ` Andi Kleen
2005-01-13 22:59 ` Ed L Cashin
2005-01-13 17:35 ` [PATCH] " Ed L Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050113000949.A7449@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox