[PATCH] reintroduce EXPORT_SYMBOL(task_nice) for binfmt_elf32

[PATCH] reintroduce EXPORT_SYMBOL(task_nice) for binfmt_elf32

[Christian Borntraeger]

Building an s390x kernel with binfmt_elf32 as a module, I get the following 
errors: 
*** Warning: "task_nice" [arch/s390/kernel/binfmt_elf32.ko] undefined!
*** Warning: "arch_pick_mmap_layout" [arch/s390/kernel/binfmt_elf32.ko] 
undefined!


IIRC 2.6.8 did not show this problem. Therefore I suggest to revert the 
removal of the EXPORT_SYMBOL(task_nice). The rationale for removing the 
export was the fact, that binfmt_elf is no longer modular. Unfortunately 
that is not true in the emulation case on s390 and (untested) sparc64. 

If there are no objections, please apply. 

--- a/kernel/sched.c	2005-01-12 01:42:35 +01:00
+++ b/kernel/sched.c	2005-01-12 23:25:22 +01:00
@@ -3187,6 +3187,8 @@
 	return TASK_NICE(p);
 }
 
+EXPORT_SYMBOL(task_nice);
+
 /**
  * idle_cpu - is a given cpu idle currently?
  * @cpu: the processor in question.

Re: [PATCH] reintroduce EXPORT_SYMBOL(task_nice) for binfmt_elf32

[Christoph Hellwig]

On Thu, Jan 13, 2005 at 08:42:30PM +0100, Christian Borntraeger wrote:
> export was the fact, that binfmt_elf is no longer modular. Unfortunately 
> that is not true in the emulation case on s390 and (untested) sparc64. 

I'd suggest putting it under CONFIG_COMPAT.

Re: [PATCH] reintroduce EXPORT_SYMBOL(task_nice) for binfmt_elf32

[Christian Borntraeger]

Christoph Hellwig wrote:
> On Thu, Jan 13, 2005 at 08:42:30PM +0100, Christian Borntraeger wrote:
> > export was the fact, that binfmt_elf is no longer modular.
> > Unfortunately that is not true in the emulation case on s390 and
> > (untested) sparc64.
>
> I'd suggest putting it under CONFIG_COMPAT.

Agreed. Better?

Signed-Off: Christian Borntraeger <cborntra@de.ibm.com>

--- a/kernel/sched.c	2005-01-12 01:42:35 +01:00
+++ b/kernel/sched.c	2005-01-13 21:59:15 +01:00
@@ -3187,6 +3187,10 @@
 	return TASK_NICE(p);
 }
 
+#ifdef CONFIG_COMPAT
+EXPORT_SYMBOL(task_nice);
+#endif
+
 /**
  * idle_cpu - is a given cpu idle currently?
  * @cpu: the processor in question.

Re: [PATCH] reintroduce EXPORT_SYMBOL(task_nice) for binfmt_elf32

[Christoph Hellwig]

On Thu, Jan 13, 2005 at 10:02:24PM +0100, Christian Borntraeger wrote:
> Agreed. Better?

Looks fine.

Although a little comment explaining what it's exported for might be
nice ;-)  So people can't complain if it's unexported if binfmt_elf
doesn't need it anymore one day.

Re: [PATCH] reintroduce EXPORT_SYMBOL(task_nice) for binfmt_elf32

[Christian Borntraeger]

Christoph Hellwig wrote:
> Although a little comment explaining what it's exported for might be
> nice ;-)  So people can't complain if it's unexported if binfmt_elf
> doesn't need it anymore one day.

OK. I dont mind if you apply this patch or the former one without the 
comment. Whatever you prefer. 

Signed-off-by: Christian Borntraeger <cborntra@de.ibm.com>

--- a/kernel/sched.c	2005-01-12 01:42:35 +01:00
+++ b/kernel/sched.c	2005-01-13 23:21:01 +01:00
@@ -3187,6 +3187,15 @@
 	return TASK_NICE(p);
 }
 
+/*
+ * The only users of task_nice are binfmt_elf and binfmt_elf32.
+ * binfmt_elf is no longer modular, but binfmt_elf32 still is.
+ * Therefore, task_nice is needed if there is a compat_mode. 
+ */
+#ifdef CONFIG_COMPAT
+EXPORT_SYMBOL(task_nice);
+#endif
+
 /**
  * idle_cpu - is a given cpu idle currently?
  * @cpu: the processor in question.