From: Greg KH <greg@kroah.com>
To: John Rose <johnrose@austin.ibm.com>
Cc: Jesse Barnes <jbarnes@engr.sgi.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] release_pcibus_dev() crash
Date: Thu, 13 Jan 2005 13:05:01 -0800 [thread overview]
Message-ID: <20050113210501.GA31402@kroah.com> (raw)
In-Reply-To: <1105649679.30960.27.camel@sinatra.austin.ibm.com>
On Thu, Jan 13, 2005 at 02:54:39PM -0600, John Rose wrote:
> > Care to redo this?
>
> Good points. How's this:
Closer (you forgot a changelog entry too...)
> }
> #else /* !HAVE_PCI_LEGACY */
> static inline void pci_create_legacy_files(struct pci_bus *bus) { return; }
> -static inline void pci_remove_legacy_files(struct pci_bus *bus) { return; }
> +void pci_remove_legacy_files(struct pci_bus *bus) { return; }
> #endif /* HAVE_PCI_LEGACY */
What about the HAVE_PCI_LEGACY version of the file?
thanks,
greg k-h
next prev parent reply other threads:[~2005-01-13 21:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-13 0:39 [PATCH] release_pcibus_dev() crash John Rose
2005-01-13 0:55 ` Jesse Barnes
2005-01-13 17:11 ` John Rose
2005-01-13 17:33 ` Jesse Barnes
2005-01-13 17:49 ` John Rose
2005-01-13 18:18 ` Greg KH
2005-01-13 18:21 ` Jesse Barnes
2005-01-13 18:37 ` Greg KH
2005-01-13 20:12 ` John Rose
2005-01-13 20:25 ` Greg KH
2005-01-13 20:54 ` John Rose
2005-01-13 21:05 ` Greg KH [this message]
2005-01-13 21:17 ` John Rose
2005-01-13 21:55 ` John Rose
2005-01-13 23:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050113210501.GA31402@kroah.com \
--to=greg@kroah.com \
--cc=jbarnes@engr.sgi.com \
--cc=johnrose@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox