public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc64-dev@ozlabs.org, mjw@us.ibm.com
Cc: Paul Mackerras <paulus@samba.org>,
	Anton Blanchard <anton@samba.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPC64: 32bit wrapper for ioctls.
Date: Fri, 14 Jan 2005 10:23:07 +0100	[thread overview]
Message-ID: <200501141023.08156.arnd@arndb.de> (raw)
In-Reply-To: <41E6C1FF.4000203@us.ltcfwd.linux.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

On Dunnersdag 13 Januar 2005 19:46, Mike Wolf wrote:
> Hi Paul,
>   The patch adds some 32bit wrappers for 2 ioctls that Java needs.
> Assuming this doesn't generate a round of discussion, please
> forward upstream to akpm/torvalds.

Why add them to arch/ppc64? These don't look architecture specific, so they
should go into include/linux/compat_ioctl.h. 

> --- linus-0112.orig/arch/ppc64/kernel/ioctl32.c 2005-01-13 10:35:10.165539000 -0600
> +++ linus-0112/arch/ppc64/kernel/ioctl32.c      2005-01-13 10:51:43.450433277 -0600
> @@ -43,6 +43,8 @@
>  COMPATIBLE_IOCTL(TIOCSTART)
>  COMPATIBLE_IOCTL(TIOCSTOP)
>  COMPATIBLE_IOCTL(TIOCSLTC)
> +COMPATIBLE_IOCTL(TIOCMIWAIT)

Note that TIOCMIWAIT is not COMPATIBLE_IOCTL, but ULONG_IOCTL. It doesn't make
a difference for ppc64, but if you add it to the generic file that is needed for
s390x.

	Arnd <><



[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2005-01-14  9:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-13 18:46 [PATCH] PPC64: 32bit wrapper for ioctls Mike Wolf
2005-01-14  9:23 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501141023.08156.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=mjw@us.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox