public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Karim Yaghmour <karim@opersys.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	LTT-Dev <ltt-dev@shafik.org>
Subject: Re: [PATCH 2/8 ] ltt for 2.6.10 : core headers
Date: Fri, 14 Jan 2005 21:55:07 +0100	[thread overview]
Message-ID: <20050114205507.GD8385@mars.ravnborg.org> (raw)
In-Reply-To: <41E76279.5020507@opersys.com>

Hi Karim.

> +++ linux-2.6.10-relayfs-ltt/include/linux/ltt-core.h	2005-01-13 22:21:56.000000000 -0500
> @@ -0,0 +1,430 @@
> +/*
> + * linux/include/linux/ltt-core.h
> + *
> + * Copyright (C) 1999-2004 Karim Yaghmour (karim@opersys.com)
> + *
> + * This contains the core definitions for the Linux Trace Toolkit.
> + */
include/linux/*.h is supposed to include only definitions used by other
parts of the kernel.
Definitions used only internally by ltt shall stay in kernel/

This is generally agreed upon, but not yet common practice.

Btw. did you run it through sparse?
Not that I found something, but did not see sparse annotation at first
sight.

	Sam

  reply	other threads:[~2005-01-14 21:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-14  6:11 [PATCH 2/8 ] ltt for 2.6.10 : core headers Karim Yaghmour
2005-01-14 20:55 ` Sam Ravnborg [this message]
2005-01-14 21:54   ` Karim Yaghmour
2005-01-14 22:48     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050114205507.GD8385@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=karim@opersys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@shafik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox