Re: Linux 2.4.29-rc2

[Adrian Bunk <bunk@stusta.de>]

On Sat, Jan 15, 2005 at 09:43:09AM -0200, Marcelo Tosatti wrote:
> 
> Hi Adrian!
> 
> On Sat, Jan 15, 2005 at 06:20:50AM +0100, Adrian Bunk wrote:
> > On Fri, Jan 14, 2005 at 11:55:55PM +0100, Steffen Moser wrote:
> > 
> > >...
> > >  - fsa01 (problem occurs):
> > >...
> > >  | modutils               2.4.5
> > >...
> > >  - gateway (no problem):
> > >...
> > >  | modutils               2.4.12
> > >....
> > 
> > OK, this seems to be the problem:
> > modutils before 2.4.10 don't know about EXPORT_SYMBOL_GPL.
> > 
> > Please upgrade modutils on fsa01 and report whether it fixes the 
> > problem.
> 
> Yes, thats the right solution - however I think it might be worth to have 
> the non-GPL versions. Several old distros ship modutils older than 2.4.10
> - eg SuSE Linux 7.1 (Oct 2001).
>...

Do a grep for EXPORT_SYMBOL_GPL in the 2.4.29-rc2 sources.

It seems for some reason people didn't scream in older 2.4 releases that 
already had the same problem in several places.

I see you have applied both my patch documenting modutils 2.4.10 was 
required and the EXPORT_SYMBOL_GPL -> EXPORT_SYMBOL patch for tty_io.c .

I don't like this mixed approach. IMHO, there are two clean solutions:
1. document modutils 2.4.10 was required, undo the EXPORT_SYMBOL_GPL -> 
   EXPORT_SYMBOL changes in tty_io.c
2. undo the EXPORT_SYMBOL_GPL -> EXPORT_SYMBOL changes in tty_io.c and
   change module.h to #define EXPORT_SYMBOL_GPL to EXPORT_SYMBOL

Both approaches have their obvious advantages and disadvantages, but 
they don't have the flaw that they special case tty_io.c .

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed