public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Anton Blanchard <anton@samba.org>
Cc: linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: ppc64 xics.c: what is smp_threads_ready exactly used for?
Date: Sun, 16 Jan 2005 06:26:56 +0100	[thread overview]
Message-ID: <20050116052655.GN4274@stusta.de> (raw)
In-Reply-To: <20050116051904.GP6309@krispykreme.ozlabs.ibm.com>

On Sun, Jan 16, 2005 at 04:19:04PM +1100, Anton Blanchard wrote:
>  
> Hi,

Hi Anton,

> > during a cleanup, I stumbled upon the following:
> > 
> > 
> > arch/ppc64/kernel/smp.c (in 2.6.11-rc1-mm1) says:
> > 
> >         /* XXX fix this, xics currently relies on it - Anton */
> >         smp_threads_ready = 1;
> > 
> > 
> > arch/ppc64/kernel/xics.c is the _only_ place in the whole kernel where 
> > smp_threads_ready is actually used, and this is the _only_ place where 
> > smp_threads_ready ever changes it's value on ppc64.
> 
> It turns out I was about to submit a patch to remove the ppc64 use of
> smp_threads_ready. With that patch it makes sense to kill
> smp_threads_ready completely.

I've got a patch ready to remove smp_threads_ready on all architectures.

The only part I still need ids how to replace it in xics.c, since this 
is the only read access to this variable on all architectures.

Could you send me this part for inclusion into my patch?

> Anton

TIA
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-01-16  5:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-16  4:33 ppc64 xics.c: what is smp_threads_ready exactly used for? Adrian Bunk
2005-01-16  5:19 ` Anton Blanchard
2005-01-16  5:26   ` Adrian Bunk [this message]
2005-01-16  5:55   ` [PATCH] ppc64: Remove CONFIG_IRQ_ALL_CPUS Anton Blanchard
2005-01-16  7:24     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050116052655.GN4274@stusta.de \
    --to=bunk@stusta.de \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox