* [2.6 patch] i386/mach-default/topology.c: make cpu_devices static
@ 2005-01-16 7:57 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-01-16 7:57 UTC (permalink / raw)
To: colpatch; +Cc: linux-kernel
The patch below makes a needlessly global struct static.
diffstat output:
arch/i386/mach-default/topology.c | 2 +-
include/asm-i386/cpu.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old 2005-01-16 05:41:55.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h 2005-01-16 05:42:09.000000000 +0100
@@ -12,7 +12,6 @@
struct i386_cpu {
struct cpu cpu;
};
-extern struct i386_cpu cpu_devices[NR_CPUS];
extern int arch_register_cpu(int num);
#ifdef CONFIG_HOTPLUG_CPU
extern void arch_unregister_cpu(int);
--- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.000000000 +0100
@@ -30,7 +30,7 @@
#include <linux/nodemask.h>
#include <asm/cpu.h>
-struct i386_cpu cpu_devices[NR_CPUS];
+static struct i386_cpu cpu_devices[NR_CPUS];
int arch_register_cpu(int num){
struct node *parent = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] i386/mach-default/topology.c: make cpu_devices static
@ 2005-01-31 23:42 Adrian Bunk
2005-02-02 23:14 ` Matthew Dobson
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-01-31 23:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: colpatch, linux-kernel
This patch makes a needlessly global struct static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/i386/mach-default/topology.c | 2 +-
include/asm-i386/cpu.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
This patch was already sent on:
- 16 Jan 2005
--- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old 2005-01-16 05:41:55.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h 2005-01-16 05:42:09.000000000 +0100
@@ -12,7 +12,6 @@
struct i386_cpu {
struct cpu cpu;
};
-extern struct i386_cpu cpu_devices[NR_CPUS];
extern int arch_register_cpu(int num);
#ifdef CONFIG_HOTPLUG_CPU
extern void arch_unregister_cpu(int);
--- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.000000000 +0100
@@ -30,7 +30,7 @@
#include <linux/nodemask.h>
#include <asm/cpu.h>
-struct i386_cpu cpu_devices[NR_CPUS];
+static struct i386_cpu cpu_devices[NR_CPUS];
int arch_register_cpu(int num){
struct node *parent = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] i386/mach-default/topology.c: make cpu_devices static
2005-01-31 23:42 Adrian Bunk
@ 2005-02-02 23:14 ` Matthew Dobson
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Dobson @ 2005-02-02 23:14 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
Looks good to me!
Acked-by: Matthew Dobson <colpatch@us.ibm.com>
Adrian Bunk wrote:
>This patch makes a needlessly global struct static.
>
>Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
>---
>
> arch/i386/mach-default/topology.c | 2 +-
> include/asm-i386/cpu.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>This patch was already sent on:
>- 16 Jan 2005
>
>--- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old 2005-01-16 05:41:55.000000000 +0100
>+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h 2005-01-16 05:42:09.000000000 +0100
>@@ -12,7 +12,6 @@
> struct i386_cpu {
> struct cpu cpu;
> };
>-extern struct i386_cpu cpu_devices[NR_CPUS];
> extern int arch_register_cpu(int num);
> #ifdef CONFIG_HOTPLUG_CPU
> extern void arch_unregister_cpu(int);
>--- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.000000000 +0100
>+++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.000000000 +0100
>@@ -30,7 +30,7 @@
> #include <linux/nodemask.h>
> #include <asm/cpu.h>
>
>-struct i386_cpu cpu_devices[NR_CPUS];
>+static struct i386_cpu cpu_devices[NR_CPUS];
>
> int arch_register_cpu(int num){
> struct node *parent = NULL;
>
>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-02 23:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-16 7:57 [2.6 patch] i386/mach-default/topology.c: make cpu_devices static Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-01-31 23:42 Adrian Bunk
2005-02-02 23:14 ` Matthew Dobson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox