* [2.6 patch] i386/power/cpu.c: remove three unused variables
@ 2005-01-16 8:11 Adrian Bunk
2005-01-17 15:27 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-01-16 8:11 UTC (permalink / raw)
To: Pavel Machek, Patrick Mochel; +Cc: linux-kernel
The patch below removes three unused variables.
Please check whether this patch is correct, or whether the variables
should have been used.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc1-mm1-full/arch/i386/power/cpu.c.old 2005-01-16 05:51:42.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/i386/power/cpu.c 2005-01-16 05:52:02.000000000 +0100
@@ -28,8 +28,7 @@
static struct saved_context saved_context;
-unsigned long saved_context_eax, saved_context_ebx;
-unsigned long saved_context_ecx, saved_context_edx;
+unsigned long saved_context_ebx;
unsigned long saved_context_esp, saved_context_ebp;
unsigned long saved_context_esi, saved_context_edi;
unsigned long saved_context_eflags;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] i386/power/cpu.c: remove three unused variables
2005-01-16 8:11 [2.6 patch] i386/power/cpu.c: remove three unused variables Adrian Bunk
@ 2005-01-17 15:27 ` Pavel Machek
2005-01-18 18:31 ` H. Peter Anvin
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2005-01-17 15:27 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Patrick Mochel, linux-kernel, hubicka
Hi!
> The patch below removes three unused variables.
>
> Please check whether this patch is correct, or whether the variables
> should have been used.
The patch is probably correct (assuming %eax, %ecx and %edx are
caller-saved on i386. [Honza, please confirm... I do not know i386
calling convention by heart.]
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] i386/power/cpu.c: remove three unused variables
2005-01-17 15:27 ` Pavel Machek
@ 2005-01-18 18:31 ` H. Peter Anvin
0 siblings, 0 replies; 4+ messages in thread
From: H. Peter Anvin @ 2005-01-18 18:31 UTC (permalink / raw)
To: linux-kernel
Followup to: <20050117152727.GB1379@elf.ucw.cz>
By author: Pavel Machek <pavel@ucw.cz>
In newsgroup: linux.dev.kernel
>
> Hi!
>
> > The patch below removes three unused variables.
> >
> > Please check whether this patch is correct, or whether the variables
> > should have been used.
>
> The patch is probably correct (assuming %eax, %ecx and %edx are
> caller-saved on i386. [Honza, please confirm... I do not know i386
> calling convention by heart.]
> Pavel
%eax, %ecx, %edx, the FPU stack, the fsw, the XMM registers, and the
arithmetric flags are caller-saved.
I *think* eflags.df is also caller-saved.
-hpa
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] i386/power/cpu.c: remove three unused variables
@ 2005-03-11 18:16 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-03-11 18:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: Pavel Machek, Patrick Mochel, linux-kernel, H. Peter Anvin
This patch removes three unused variables.
Pavel Machek and H. Peter Anvin have already confirmed it's correct.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 16 Jan 2005
--- linux-2.6.11-rc1-mm1-full/arch/i386/power/cpu.c.old 2005-01-16 05:51:42.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/i386/power/cpu.c 2005-01-16 05:52:02.000000000 +0100
@@ -28,8 +28,7 @@
static struct saved_context saved_context;
-unsigned long saved_context_eax, saved_context_ebx;
-unsigned long saved_context_ecx, saved_context_edx;
+unsigned long saved_context_ebx;
unsigned long saved_context_esp, saved_context_ebp;
unsigned long saved_context_esi, saved_context_edi;
unsigned long saved_context_eflags;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-03-11 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-16 8:11 [2.6 patch] i386/power/cpu.c: remove three unused variables Adrian Bunk
2005-01-17 15:27 ` Pavel Machek
2005-01-18 18:31 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2005-03-11 18:16 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox