From: Jean Delvare <khali@linux-fr.org>
To: Greg KH <greg@kroah.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
LM Sensors <sensors@stimpy.netroedge.com>
Subject: [PATCH 2.6] I2C: Kill i2c_client.id
Date: Sun, 16 Jan 2005 19:46:53 +0100 [thread overview]
Message-ID: <20050116194653.17c96499.khali@linux-fr.org> (raw)
Hi Greg,
As discussed earlier on the LKML [1], here comes a patch set killing the
id member of the i2c_client structure. Let me recap my main reasons for
doing so:
1* A client is already uniquely identified by the combination of the
number of the bus it sits on and the address it is located at on this
bus.
2* The i2c core doesn't make use of this struct member. Such an id, if
needed, would thus be private data and as such would belong to the data
member. In fact, none of the drivers using this field really needs it as
far as I could see.
Killing that useless struct member will let us save some memory and kill
some useless code (not much, admittedly).
I will send 5 different patches, to be applied in order, although
nothing critical will happen if applied in a different order. In each
patch, most chucks are themselves independent from each other, so if any
is rejected or delayed for some reason, the rest can still be applied.
(1/5) Stop using i2c_client.id in i2c/chips drivers (mostly hardware
monitoring drivers).
(2/5) Stop using i2c_client.id in media/video drivers.
(3/5) Stop using i2c_client.id in misc drivers.
(4/5) Deprecate i2c_client.id.
(5/5) Documentation update.
Thanks.
[1] http://lkml.org/lkml/2004/12/27/132
--
Jean Delvare
http://khali.linux-fr.org/
next reply other threads:[~2005-01-16 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-16 18:46 Jean Delvare [this message]
2005-01-16 19:10 ` [PATCH 2.6] I2C: Kill i2c_client.id (1/5) Jean Delvare
2005-01-16 19:27 ` [PATCH 2.6] I2C: Kill i2c_client.id (2/5) Jean Delvare
2005-01-16 19:39 ` [PATCH 2.6] I2C: Kill i2c_client.id (3/5) Jean Delvare
2005-01-16 19:46 ` [PATCH 2.6] I2C: Kill i2c_client.id (4/5) Jean Delvare
2005-01-16 19:49 ` [PATCH 2.6] I2C: Kill i2c_client.id (5/5) Jean Delvare
2005-01-19 23:37 ` [PATCH 2.6] I2C: Kill i2c_client.id Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050116194653.17c96499.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox