* [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr
@ 2005-01-16 7:48 Adrian Bunk
2005-01-17 5:50 ` Andi Kleen
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-01-16 7:48 UTC (permalink / raw)
To: ak; +Cc: discuss, linux-kernel
I didn't know the x86_64 port supports the Centaur CPU. ;-)
diffstat output:
include/asm-x86_64/mtrr.h | 3 ---
1 files changed, 3 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.11-rc1-mm1-full/include/asm-x86_64/mtrr.h.old 2005-01-16 04:27:41.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-x86_64/mtrr.h 2005-01-16 04:27:54.000000000 +0100
@@ -79,7 +79,6 @@
unsigned int type, char increment);
extern int mtrr_del (int reg, unsigned long base, unsigned long size);
extern int mtrr_del_page (int reg, unsigned long base, unsigned long size);
-extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi);
# else
static __inline__ int mtrr_add (unsigned long base, unsigned long size,
unsigned int type, char increment)
@@ -102,8 +101,6 @@
return -ENODEV;
}
-static __inline__ void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) {}
-
# endif
#endif
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr
2005-01-16 7:48 [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr Adrian Bunk
@ 2005-01-17 5:50 ` Andi Kleen
2005-01-17 6:07 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2005-01-17 5:50 UTC (permalink / raw)
To: Adrian Bunk; +Cc: ak, discuss, linux-kernel
On Sun, Jan 16, 2005 at 08:48:17AM +0100, Adrian Bunk wrote:
> I didn't know the x86_64 port supports the Centaur CPU. ;-)
Have you actually compiled this? Most of the gunk in asm-x86_64/mtrr.h
is because we share the MTRR driver with i386, and there is no good
way to disable specific CPUs in there.
-Andi
>
>
> diffstat output:
> include/asm-x86_64/mtrr.h | 3 ---
> 1 files changed, 3 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.11-rc1-mm1-full/include/asm-x86_64/mtrr.h.old 2005-01-16 04:27:41.000000000 +0100
> +++ linux-2.6.11-rc1-mm1-full/include/asm-x86_64/mtrr.h 2005-01-16 04:27:54.000000000 +0100
> @@ -79,7 +79,6 @@
> unsigned int type, char increment);
> extern int mtrr_del (int reg, unsigned long base, unsigned long size);
> extern int mtrr_del_page (int reg, unsigned long base, unsigned long size);
> -extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi);
> # else
> static __inline__ int mtrr_add (unsigned long base, unsigned long size,
> unsigned int type, char increment)
> @@ -102,8 +101,6 @@
> return -ENODEV;
> }
>
> -static __inline__ void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) {}
> -
> # endif
>
> #endif
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr
2005-01-17 5:50 ` Andi Kleen
@ 2005-01-17 6:07 ` Adrian Bunk
2005-01-17 6:16 ` Andi Kleen
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-01-17 6:07 UTC (permalink / raw)
To: Andi Kleen; +Cc: discuss, linux-kernel
On Mon, Jan 17, 2005 at 06:50:40AM +0100, Andi Kleen wrote:
> On Sun, Jan 16, 2005 at 08:48:17AM +0100, Adrian Bunk wrote:
> > I didn't know the x86_64 port supports the Centaur CPU. ;-)
>
> Have you actually compiled this? Most of the gunk in asm-x86_64/mtrr.h
> is because we share the MTRR driver with i386, and there is no good
> way to disable specific CPUs in there.
If X86_64 wouldn't have hijyacked CONFIG_X86, you could simply put
obj-$(CONFIG_X86) there...
I haven't tried to compile it, but OTOH I haven't yet found which dirty
tricks you are using for compiling arch/i386/kernel/cpu/centaur.c on
x86_64...
> -Andi
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr
2005-01-17 6:07 ` Adrian Bunk
@ 2005-01-17 6:16 ` Andi Kleen
2005-01-17 8:43 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2005-01-17 6:16 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andi Kleen, discuss, linux-kernel
On Mon, Jan 17, 2005 at 07:07:46AM +0100, Adrian Bunk wrote:
> I haven't tried to compile it, [...]
Please only submit compile tested patches in the future.
A cross compiler for x86-64 from i386 can be found at
ftp://ftp.suse.com/pub/suse/x86_64/supplementary/CrossTools/8.1-i386/
(work with alien or rpm2cpio on non rpm systems too)
-Andi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr
2005-01-17 6:16 ` Andi Kleen
@ 2005-01-17 8:43 ` Adrian Bunk
2005-01-17 9:25 ` Andi Kleen
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-01-17 8:43 UTC (permalink / raw)
To: Andi Kleen; +Cc: discuss, linux-kernel
On Mon, Jan 17, 2005 at 07:16:33AM +0100, Andi Kleen wrote:
> On Mon, Jan 17, 2005 at 07:07:46AM +0100, Adrian Bunk wrote:
> > I haven't tried to compile it, [...]
>
> Please only submit compile tested patches in the future.
>
> A cross compiler for x86-64 from i386 can be found at
> ftp://ftp.suse.com/pub/suse/x86_64/supplementary/CrossTools/8.1-i386/
> (work with alien or rpm2cpio on non rpm systems too)
I tried this, but wasn't able to repruduce the compile error you
observed.
Could you send me the .config you observed the problem with?
> -Andi
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr
2005-01-17 8:43 ` Adrian Bunk
@ 2005-01-17 9:25 ` Andi Kleen
0 siblings, 0 replies; 6+ messages in thread
From: Andi Kleen @ 2005-01-17 9:25 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andi Kleen, discuss, linux-kernel
On Mon, Jan 17, 2005 at 09:43:49AM +0100, Adrian Bunk wrote:
> On Mon, Jan 17, 2005 at 07:16:33AM +0100, Andi Kleen wrote:
> > On Mon, Jan 17, 2005 at 07:07:46AM +0100, Adrian Bunk wrote:
> > > I haven't tried to compile it, [...]
> >
> > Please only submit compile tested patches in the future.
> >
> > A cross compiler for x86-64 from i386 can be found at
> > ftp://ftp.suse.com/pub/suse/x86_64/supplementary/CrossTools/8.1-i386/
> > (work with alien or rpm2cpio on non rpm systems too)
>
> I tried this, but wasn't able to repruduce the compile error you
> observed.
>
> Could you send me the .config you observed the problem with?
I didn't see a problem, just asked if it really compiles. You're
right that centaur is not linked in so it'll probably work.
I'll apply the patch, thanks.
-Andi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-01-17 9:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-16 7:48 [2.6 patch] x86_64: kill stale mtrr_centaur_report_mcr Adrian Bunk
2005-01-17 5:50 ` Andi Kleen
2005-01-17 6:07 ` Adrian Bunk
2005-01-17 6:16 ` Andi Kleen
2005-01-17 8:43 ` Adrian Bunk
2005-01-17 9:25 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox