* [2.6 patch] mm/thrash.c: make a variable static
@ 2005-01-17 8:13 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-01-17 8:13 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Rik van Riel
This patch makes a needlessly global variable static.
It was already ACK'ed by Rik van Riel.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 12 Dec 2004
--- linux-2.6.10-rc2-mm4-full/mm/thrash.c.old 2004-12-12 04:00:18.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/mm/thrash.c 2004-12-12 04:00:25.000000000 +0100
@@ -15,7 +15,7 @@
static DEFINE_SPINLOCK(swap_token_lock);
static unsigned long swap_token_timeout;
-unsigned long swap_token_check;
+static unsigned long swap_token_check;
struct mm_struct * swap_token_mm = &init_mm;
#define SWAP_TOKEN_CHECK_INTERVAL (HZ * 2)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] mm/thrash.c: make a variable static
@ 2004-12-12 20:03 Adrian Bunk
2004-12-12 22:53 ` Rik van Riel
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2004-12-12 20:03 UTC (permalink / raw)
To: linux-kernel, Rik van Riel
The patch below makes a needlessly global variable static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm4-full/mm/thrash.c.old 2004-12-12 04:00:18.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/mm/thrash.c 2004-12-12 04:00:25.000000000 +0100
@@ -15,7 +15,7 @@
static DEFINE_SPINLOCK(swap_token_lock);
static unsigned long swap_token_timeout;
-unsigned long swap_token_check;
+static unsigned long swap_token_check;
struct mm_struct * swap_token_mm = &init_mm;
#define SWAP_TOKEN_CHECK_INTERVAL (HZ * 2)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] mm/thrash.c: make a variable static
2004-12-12 20:03 Adrian Bunk
@ 2004-12-12 22:53 ` Rik van Riel
0 siblings, 0 replies; 3+ messages in thread
From: Rik van Riel @ 2004-12-12 22:53 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Sun, 12 Dec 2004, Adrian Bunk wrote:
> --- linux-2.6.10-rc2-mm4-full/mm/thrash.c.old 2004-12-12 04:00:18.000000000 +0100
> +++ linux-2.6.10-rc2-mm4-full/mm/thrash.c 2004-12-12 04:00:25.000000000 +0100
> -unsigned long swap_token_check;
> +static unsigned long swap_token_check;
Looks good to me.
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-17 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-17 8:13 [2.6 patch] mm/thrash.c: make a variable static Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2004-12-12 20:03 Adrian Bunk
2004-12-12 22:53 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox