From: Greg KH <greg@kroah.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: PCI patches not being reviewed
Date: Tue, 18 Jan 2005 08:29:08 -0800 [thread overview]
Message-ID: <20050118162908.GA12553@kroah.com> (raw)
In-Reply-To: <20050118122126.GM30982@parcelfarce.linux.theplanet.co.uk>
On Tue, Jan 18, 2005 at 12:21:26PM +0000, Matthew Wilcox wrote:
> On Mon, Jan 17, 2005 at 10:27:22PM -0800, Greg KH wrote:
> > On Tue, Jan 18, 2005 at 02:20:31AM +0000, Matthew Wilcox wrote:
> > >
> > > Greg, you're merging a lot of patches that aren't going through
> > > the linux-pci mailing list for review. Please redirect patches that
> > > are sent to you directly so others can also review them.
> >
> > I'm sorry, were there any that were recently applied that you feel
> > needed more review?
>
> Yes, the PCI Express bridge driver is quite buggy.
It was posted a number of times to lkml in December, and it was
commented on by a few different people, and the patch went through a few
different revisions. It also was in the -mm tree for awhile.
> I also think it's the wrong approach to take -- weren't you working on
> a generic way to have multiple drivers attach to the same device?
That's what the patch allows to happen. I think it's the right
approach, what do you think it should do?
> > All major ones have been posted to linux-kernel
> > first, which, according to the MAINTAINERS file, is the list for pci
> > issues to be disccused on. I'd be glad to change that entry, if you
> > think it would help out any.
>
> That would certainly help; I'm not sure how anyone has time to read
> linux-kernel. Here's a patch:
Hm, in sleeping on it, I think I'll leave it, as it's worked out just
fine for me for the past 2+ years I've been the PCI maintainer, this has
been the first it has come up. But if it really annoys you, how about
just adding another L: entry for it, so people can choose where they
want to go?
Oh, and you forgot the Signed-off-by: line :)
thanks,
greg k-h
next prev parent reply other threads:[~2005-01-18 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-18 2:20 PCI patches not being reviewed Matthew Wilcox
2005-01-18 6:27 ` Greg KH
2005-01-18 12:21 ` Matthew Wilcox
2005-01-18 16:29 ` Greg KH [this message]
2005-01-18 16:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050118162908.GA12553@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox