From: David Brownell <david-b@pacbell.net>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: usbmon, usb core, ARM
Date: Tue, 18 Jan 2005 22:14:24 -0800 [thread overview]
Message-ID: <200501182214.25273.david-b@pacbell.net> (raw)
In-Reply-To: <20050118212033.26e1b6f0@localhost.localdomain>
On Tuesday 18 January 2005 9:20 pm, Pete Zaitcev wrote:
>
> However, David objects to the patch on the grounds that it can damage ARM.
Actually what I said was:
> > Those patches were added for important reasons. (Or did you add some
> > other solution to the issue described in that comment?)
which on closer examination (of just this patch, split out from all
the usbmon stuff) may well have been your cue to say something like
"my solution was to add a special case for root hubs into every urb's
giveback() path ... even though I left in the comment specifying that
this must be handled in the original way".
As well as:
> > Also, I don't like the idea of scattering knowledge all over the place
> > that the root hub is always given address 1 ...
which you didn't address yet.
- Dave
next prev parent reply other threads:[~2005-01-19 6:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 5:20 usbmon, usb core, ARM Pete Zaitcev
2005-01-19 6:14 ` David Brownell [this message]
2005-01-19 15:42 ` Pete Zaitcev
2005-01-19 15:54 ` Oliver Neukum
2005-01-19 17:08 ` David Brownell
2005-01-20 19:35 ` Pete Zaitcev
2005-01-21 6:28 ` David Brownell
2005-01-22 8:12 ` Pete Zaitcev
2005-01-23 23:34 ` [linux-usb-devel] " David Brownell
2005-01-24 1:17 ` Pete Zaitcev
2005-01-24 2:08 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501182214.25273.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox